1 karl 1.1.2.1 Using the CIM/XML Pull Operations
2
3 STATUS
4
|
5 karl 1.1.2.4 <<< The TODO section is being maintained during the review and checkin process
|
6 karl 1.1.2.1 to keep track of problems, errors, notes, etc. Must be deleted before
7 checkin to head of tree. Please feel free to add notes, etc in this
8 section as you review/test.>>>>>>
9
|
10 karl 1.1.2.4 TODO list:
|
11 karl 1.1.2.3 1. Binary operation from OOP. Need to add counter to binary
12 protocol to be able to count objects in response. Generates
13 warnings in things like messageserializer and does not work with
|
14 karl 1.1.2.31 OOP right now. Fixed by converting to XML. Concluded that we do not
15 need to do this. The binary response is not really used often
16 in the current environment So double mapping it is not a major issue.
17 Leave this as FUTURE
|
18 karl 1.1.2.35 2. DONE OpenExecQuery - Code is incomplete in that it does not include the
|
19 karl 1.1.2.31 return from the exec query function to the aggregator yet. Code for Pull
|
20 karl 1.1.2.34 part of OpenQueryInstancesRequest a) should be part of the common
21 CIMOperationRequestDispatcher execCommon code. DONE, not tested. 29 May
|
22 karl 1.1.2.35 30 May tested with simple cli calls.
23 3. DONE The changes to WQLCIMOperationRequestDispatcher and CQL... for handling
|
24 karl 1.1.2.4 pull not completed so we feed the responses back to the EnmerationContext
|
25 karl 1.1.2.35 queues. DONE Not tested 29 May 30 May DONE, some testing done
26 4. Minor TODOs, diagnostics, etc. still in the code. Reduced almost to
27 none now. We are leaving some in as PEGASUS_DEBUG
|
28 karl 1.1.2.31 5. Extension to avoid double move of objects in CIMResponseData (one
|
29 karl 1.1.2.3 into enumerationContext queue and second to new cimResponseData for
30 response. Want to avoid second move by extending Open/Pull response
31 messages to include count and CIMResponse data to count objects out
|
32 karl 1.1.2.23 of queue when converting (avoids the second move). This would mean
33 extending the output writers to allow the count field to be supplied
|
34 karl 1.1.2.30 so they would only create output for up to the count supplied.(Make
|
35 karl 1.1.2.35 this future beyond bug 9676). This is fairly extensive because it
36 extends beyond CIMResponseData to SCMO and XML writers where the
37 XmlWriters used by encodeXmlResponse would have to have counters
38 added. Then instead of copying on getCache we would simply pass the
39 cache and count on and the writer would take and remove.
|
40 karl 1.1.2.31 6. Add more static tests (currently only OpenEnumerateInstances and
|
41 karl 1.1.2.30 OpenEnumerateInstanceNames covered).
|
42 karl 1.1.2.26 Low priority because most of this except exact XML covered in other
|
43 karl 1.1.2.28 tests. note that we can only add very limited tests since a) no
|
44 karl 1.1.2.31 way to test multiple operations in sequence(i.e. open/pull) and
|
45 karl 1.1.2.28 cannot be sure how many responses will come back in all cases even
|
46 karl 1.1.2.35 for open. The only reason for most of these tests is to assure that
47 we do not change XML inadvertendtly in future with change that is
48 compatible to both our server and client but breaks other clients or
49 servers. In any case we can do only minimal tests because most real
50 testing involves both open and pull and the static tests are by their
51 nature single operation.
|
52 karl 1.1.2.32 8. Correct issue between operations and HTTP where we are sending
|
53 karl 1.1.2.31 trailers with exceptions. Modify response mechanisms so that we
54 set non-chunked for all responses where we send error responses to
|
55 karl 1.1.2.35 avoid the trailers. NOTE: There should be now a bug on this in general
56 where we would want to send an initial error without the trailer. Should
57 have always done that.
|
58 karl 1.1.2.32 9. It would be more efficient in dispatcher to always use exception for
|
59 karl 1.1.2.31 rejects and change the _reject functions so that they never return
60 when they reject. This is VERY LOW PRIORITY and primarily saves
61 a few lines of code in the reject functions and their calls. Means we
62 would code.
|
63 karl 1.1.2.35 _rejectIfEnumerationToBroad(...);
64 _rejectIfThisParameterIncorrect(...);
|
65 karl 1.1.2.31
66 instead of
67 if (_rejectIfEnum...)
68 {
69 return true
70 }
71 It would mean that the method trace for the handlers would not return
|
72 karl 1.1.2.35 an exit if we rejected. VERY LOW PRIORITY. Possibly FUTURE. No behavior
73 change, just more compact source code but it messes with the method
74 trace logic.
|
75 karl 1.1.2.34 10. There are still a couple of template functions around the task of
|
76 karl 1.1.2.32 distributing requests to the multiple providers.
77 In fact there are two similiar but different templates for
|
78 karl 1.1.2.31 the associators(i.e. assoc, ref, etc.) functions and the parallel
79 openAssoc functions. It would be nice to consolidate that logic and
80 further to try to create a non-template form for those functions. LOW
|
81 karl 1.1.2.44 PRIORITY and not for bug 9676 ACTION: Define in new bug
82 11. External runtime variables. bug 9676 leaves these variables as
|
83 karl 1.1.2.37 internal to CIMOperationRequestDispatcher.cpp.
84 See bug 9819 for the changes to externalize these variables, both
85 the runtime and buildtime variables. The Work group discussion
86 documents what the variables are and how they tie to statistics info.
87 See the OpenPegasus Wiki, Pull operations work group.
|
88 karl 1.1.2.35 12. Trace functions in CIMResponseData,h & cpp should be PEGASUS_DEBUG.
|
89 karl 1.1.2.37 Same for trace function in EnumerationContext and
90 EnumerationContextTable
91 13.Question. We added trace in CIMRequestOperationDispatcher.cpp if
92 query enum is recevied with no object path. However, since this is
93 a provider problem should we be doing something other than a trace
94 (ex. log) since traces are often not really used and they do generate
95 lots of data whereby something like this could get lost. Also, need
96 to review what level of trace if we keep trace.
|
97 karl 1.1.2.36 14. Note that the build-a-class argument on OpenQueryInstances always
|
98 karl 1.1.2.44 returns error since we do not build the class. We propose to deprecate
99 this in DMTF and not implement in in OpenPegasus. TODO add a bug
100 defining this limitation. This is not a TODO, just a warning for
|
101 karl 1.1.2.37 the future. TODO add bug about this and add to release notes
|
102 karl 1.1.2.38 15. Clarify trace of completion of each enumeration sequence.
103 16. Statistics keeping for open, etc. through cimperf.
104
|
105 karl 1.1.2.26
106 NEXT TASKS:
|
107 karl 1.1.2.37 a. finish 8, 12 above. Test against cimperf since there was a bug
108 in cimperf from before.
|
109 karl 1.1.2.39
|
110 karl 1.1.2.49 20 August 2014
111 1. Update to greatly reduce the number of KS_TODO comments. We have reduce
112 the number of these comments to about 50 total of which most are comments
113 to remove diagnostics.
114 2. Internationlize a number of messages in XmlReader, etc. This completes
115 internationalization of messages added for pull operations.
116 3. Added some detailed messages to cimcli to show what is happening in
117 the multiple operations.
118 4. Some efficiency changes (ex. remove String::EMPTY usage)
119
120 18 August 2014
121 1. Update to remove some TODOs.
122 2. Mergeout to the task branch. Note that for some reason there had bee
123 a descrepency in the Pegasus/Server/Tests/TLS last bug fix not getting
124 into the previous mergeout
125
|
126 karl 1.1.2.46 14 August 2014
127 1. Issue with the pullop test in some systems causing an HTTP 413 error (
128 too much data). We confirmed that this is probably actually a limit in the
129 client with enumerate instances (the response is simply to big in the case
130 where we are asking it to deliver 100,000 responses instances on some systems)
131 Modified the test for the stress test to be 30,000 instances and added a
132 manual test testSizeLimit to the make file to try to deliver up to 600,000
133 instances to determine limits to the environment.
134
135 Note that this is not actually a failure of the pull operations. In fact
136 where cimcli ei ... fails with 600,000 instances in the response cimcli pei
137 works correctly.
138
139 Update the Client/tests/pullop/Makefile stresstests to hopefully pass the
140 nightly test on more systems.
141
142 2. Eliminated a number of KS_TODOs and code that we had documented out with
143 //// . Note that there are still a number of the KS_TODOs but most of them
144 are really isolated around
145
|
146 karl 1.1.2.47 19 August 2014
|
147 karl 1.1.2.48 1. Mergeout to head of tree. We picked up one issue that for some reason
148 the cvs mergeout was missing, a change to Server/tests/TLS...
149
150 19 August 2014
|
151 karl 1.1.2.47 1. Remove a number of KS_TODO notes either by cleaning them up or by
152 change the keyword to FUTURE if they are things that we might consider
153 for the future
154 2. Some efficiency improvements in dealing with strings primarily get
155 rid of use of String::EMPTY in the new code.
156
157 3. Removed some diagnostic trace output that was used during development.
|
158 karl 1.1.2.46
|
159 karl 1.1.2.45 13 August 2014
160 1. Mergeout to head of tree.
161
|
162 karl 1.1.2.44 11. August 2014
163 1. Correct error in compile in windows (bad reference to sleep(...)
164
|
165 karl 1.1.2.43 29 July 2014
166 1. Cleanup functionality in the unittests for EnumerationContext and
167 its table.
168
|
169 karl 1.1.2.42 23 July 2014
170 1. Mergeout from head of tree to Task branch
171
|
172 karl 1.1.2.41 21 July 2014
173 1. Removed strings.h from pullop.cpp
174 2. Minor cleanup per testing
175
|
176 karl 1.1.2.40 17 July 2014
177 1. Correct error in CIMOperationRequestDispatcher.cpp OpenQueryInstances
178 when PEGASUS_DISABLE_QUERY set.
179 2. Correct issue in diagnostic code in CIMResponseData.cpp that used
180 snprintf function not available in windows.
|
181 karl 1.1.2.41 3. Clean up some miscellaneous code in pullop and Makefile.
|
182 karl 1.1.2.40 4. Minor change to PullErrosrs.
183
|
184 karl 1.1.2.39 2 July 2014
185 1. Corrected error in the new getoopt functions that caused it to fail
186 in build and also in it unit test with the --help option.
187
188 28 June 2014
189 1. Corrected issue where ZOs was getting errors from pullop because we
190 used getopt to parse command line and the linux getopt is not behavior
191 consistent with ZOs. Note that the ZOs getopt matches the posix expect and
192 the linux one has extensions (notably it permutes non option arguments to
193 the end of the arguments array. The easiest and most logical was to move
194 the whole parser to use the internal getoopt which is what we should be
195 using all the time in any case.
|
196 karl 1.1.2.38 18 June 2014
197 1. Correct errors in pullop and CMIMessage.cpp identified by Ji Lee as comments 58,59
198 2. Correct error in Makefile identified by Ji Lee as bug comment 60
|
199 karl 1.1.2.37
200 14 June 2014
201 1. Mergeout from head of tree.
202
|
203 karl 1.1.2.36 12 June 2014
204 1. Implement the basic code for the CIMOperationDispatcher portion of bug 9819
205 Note that the CIMConfig calls are disabled with comments.
206 2. Corrected a number of differences in const declaration and definition for
|
207 karl 1.1.2.37 continueOnError and maxObjectCount in CIMClient. This corrects issue
208 documented in bug 9676 comment 53
|
209 karl 1.1.2.36 3. Corrected some documentation for Pull operations in CIMClient.
210 4. Corrected similar issue In EnumerationContext class. See comment 54
211 5. Removed ExecInfo.h header from Client/tests/PullErrors/PullErrors.cpp
|
212 karl 1.1.2.35
213 30 May 2014
214 1. Correct issue in UintArgs. Modified to use smart pointers, consistent
215 with public interfaces. Tested
216 2. Complete code for OpenQueryInstances and PullInstances so that the complete
217 sequence works for both the server and client (i.e. 2, 3 above done
218 except for more tests in pullop).
219 3. Fix issue in cimcli where the OpenQueryInstances was outputting a path
220 component where there is no path transmitted from the server.
221 4. Moved large block of common code in CQLOperationRequestDispatcher.cpp
222 and WQLOperationRequestDispatcher.cpp to common function
223 handleQueryRequestCommon in CIMOperationRequestDispatcher.cpp. These
224 handlers now reduced to just the parser processing and minimal error
225 checks.
226 5. Cleaned up some code in EnumerationContextTable.CreateContext so only
227 single interface for all requests.
228 6, Commented out a number of PEG_TRACE messages. Note that they are
229 commented with 4 /s at line beginning to be easily identified.
230 //// code
231 There are still a number of KS_TODOs but they are mostly some questsions,
232 some internationalization (note that almost none of this environment is
233 karl 1.1.2.35 completely internationlaized (see the decoders)) and a couple of questions
234 about the existing code or exactly what message should be sent. I argue
235 that the current TODOs should not stop checkin. Will remove after we
236 have tested couple of days and prove that there is no real need.
237 7. Added trace in Query response code if there is no objectPath since that
238 is really an error in the provider
239
|
240 karl 1.1.2.34
241 29 May 2014
242 1. Correct issue in cimcli that was causing rejects of open operations when
243 there were no filters requested. The standard default is WQL in cimcli
244 so we overrode this for the pull operations.
245 2. Clean up OpenQueryInstances in CIMMessage.h and CIMMessage.cpp.
246 3. Modify CIMOperationRequestDispatcher and
247 EnumerationContextTable.CreateContext to pass request rather than request
248 parameters.
249 4. Remove a number of diagnostic messages. Note that there are still some.
250 They are marked KS_TODO with with note to remove before checkin. They are
251 all traces and validations.
252 5. Correct error in inclusion of execinfo.h include in CIMOperationRequestDis.
253 found by Ji Lee.
254 6. Cleaned up execQuery and extended it for OpenQueryInstances. ExecQuery
255 tested but have not tested OpenQueryInstances yet. One more checkin and we
256 should be able to close 2,3 above (OpenQueryInstances).
|
257 karl 1.1.2.32
258 26 May 2014
259 1. Remove a number of diagnostics.
260 2. Make cache size in EnumerationContextTable dynamic and remove function
261 to set default values. MaximumEnums set from Dispatcher on constructor for
262 EnumerationContextTable and table size set to 1/2 of maximum number of
263 open contexts.
264 3. Clean up some statistics in EnumerationContextTable
|
265 karl 1.1.2.33 4. Correct error in query and queryLanguage parameters in cimcli in that
266 the default for queryLanguage is WQL but must be "" for pull operations.
267 If WQL found they set it to "".
|
268 karl 1.1.2.32
|
269 karl 1.1.2.31
270 9 May 2104
271 1. Converted several template functions in CIMOperationRequestDispatcher
272 to real functions
273 2. Added intermediate CIMMessage for CIMPullOperationRequestMessage since
274 all of the pulls have exactly the same data. This allowed us to
275 convert the template function processPullRequest from template to
276 real function
277 3. Added intermediate CIMMessage for CIMOpenOperationRequestMessage betweeh\n
278 all of the Opens and the CIMRequestData message. This will allow
279 common code to test all of these variables in all 6
280 CIMOperationRequestDispatcher handleOpen... functions
281 3. Added variable in CIMOperationRequestDispatcher handleEnqueue to make
282 releasing the original request conditional on return from the handle...
283 for open... and pull... handlers.
284 This allowed us to drop one place where we were creating a new request msg
285 for the delayed response and use the original request. This meant that
286 we could convert the issueOpenOrPullResponse from template function to
287 real function.
288 4. Moved open and pull constructors in CIMMessage.h to CIMMessage.cpp. NOTE:
289 openQueryInstances not moved. Will do when we get this funciton running.
290 karl 1.1.2.31 5. Added test for correct namespace in pull operations. Note that it is
291 never really used but since supplied with request, we test to be sure it is
292 same as open request namespace. added internationalized exception for this.
293 6. We should probably add same test to close just as an input parameter
294 validation.
295 6. Modified processPullRequest to close the enumeration context if
296 incorrect response type received. Before we just returned exception and
297 left context open for next request. Closing is much more logical since the
298 client really did send an erronous request.
299 7. Modified PullErrors to correctly test above changed in behavior.
300 8. Removed a significant number of diagnostic messages.
|
301 karl 1.1.2.33 9. Added query and querylanguage parameters to cimcli.
|
302 karl 1.1.2.31
|
303 karl 1.1.2.23
|
304 karl 1.1.2.30 4 May 2014
305 1. Clean interface with EnumerationContext timeout thread
306 2. Remove more diagnostics
307 3. Correct issue with enumerationContext Release that was causing
308 failures during nightly tests.
309
|
310 karl 1.1.2.29 2 May 2014
311 1. Remove Diagnostics from ResponseData.cpp
312 2. Correct setup and start of EnumerationContextTimerThread
313 3. Change limit on max number of enum contexts to be set from Dispatcher.
314 4. Increase size of hashtable for enum contexts.
315 5. Corrected issue causing failures in removeContext. Now runs through nightly
316 tests most of the time.
|
317 karl 1.1.2.28 1 May 2014
318 1. Cleanup of code and variable names.
319 2. Removed namespace variable from EnumerationContext. It was never used.
320 3. Added test for max number of open enumerations. Right now it is fixed
321 and set about 100. Note that this is tied to the size of hash table
322 so that there is a issue with more dynamic setting of max and the
323 hash table size.
324 4. Removed several unused functions.
325 5. Found one possible issue causing thread conflict but not the core one
326 yet.
327
328 30 April
329 1. Added exception response to dispatcher for Limits exceeded on
330 CreateEnumerationContext. Returns Exceeded server limits CIMException.
331 2. Fixed possible deadlock where we were not unlocking EnumerationContext
332 under error condition
333
334
|
335 karl 1.1.2.27 27 April - mergeout to head of tree
336 1. Mergeout of the code to the head of tree. Documented that mergeout in
337 the bug
338
339 27 April 2014
340 1. Clean up in a number of areas, mostly just code without changing
341 functionality.
342 2. Modified CIMMessage.h slightly to clarify names of the pull intermediate
343 messages (the common open and pull response);
344 3. Removed a number of diagnostics from CIMResponseData
345 4. Added new function to ResponseStressTestProvider to be able to terminate
346 output after a defined number of objects with a CIMException.
347 5. Removed a number of other TODOs
348 6. Corrected a couple of errors in the server message bundle.
349 7. Modified ResponseEncoder to only output the error for pull errors.
350 It was errounously outputting the EndOfSequence, EnumerationContext and
351 the error. This way, only the error is sent which is spec.
352 8. Removed number of TODOs and cleaned up a couple of others.
353 9. Added static tests for OpenEnumerateInstanceNames.
354 10. Modified a number of the temporary diagnostics to be permanent by
355 changing them to PEGASUS_DEBUG_ASSERTs
356 karl 1.1.2.27
|
357 karl 1.1.2.24 22 April 2014
358 1. Clean up some messages.
359 2. Still trying to find issue that randomly keeps messages in timeout
360 queue long after they have been closed and returned.
|
361 karl 1.1.2.25 3. Fixed memory loss error.
|
362 karl 1.1.2.26 4. Added zero reject for OperationTimeout because that effectively disables
363 the whole timeout mechanism so that enumerations could be started, never
364 completed by the client and would just hang around in memory. That
365 would be a significant DDOS attack (start very large enum with no
366 timeout) and never do pulls after open.
|
367 karl 1.1.2.25
|
368 karl 1.1.2.23 21 April 2014
|
369 karl 1.1.2.27 1. Reorganized code in CIMOperationRequestDecoder.cpp ...Iparam classes.
|
370 karl 1.1.2.23 Cleaned up the rejectCIMException code.
371 2. Cleanup some issues in the EnumerationContextTimeout Thread.
372 3. Fixed issue in pullop where it was using zero as default for default
373 operation timeout where it should have been NULL, the DMTF specified
374 default.
375 4. Enabled the test to reject 0 as operation timeout on a request and but
376 controled by a #define in CIMOperationRequestDispatcher.cpp
377 5. Added test for excessive new OperationContext entries in table.
378
379 18 April 2014
380 1. Internationalize remaining messages in CIMOperationRequestDecoder.cpp and
381 clean up the decoders for some of the messages so they use the
382 ...Iparam classes. Note that we did not clean up all of the old message
383 decoders, just the new ones and we did not clean up the Count message
384 since it is deprecated. TODO clean these up so the decoder is really
385 consistent.
386 2. Enabled the EnumerationContext Timer and removed code for alternate
387 non-thread solution.
|
388 karl 1.1.2.16
|
389 karl 1.1.2.21 17 April 2014
390 1. Reorganized the lock/unlock for handling the EnumerationContext because
391 there were thread windows (i.e. using the context after it was released
392 by other thread).
393 2. Modified code for the InteroperationTimerThread and deleted old code that
394 allowed this whole thread to by bypassed.
395 3. Internationalized a number of CIMOperationRequestDispatcher CIMException
396 response messages.
|
397 karl 1.1.2.22 4. Fixed stress tests in Client/tests/pullop that were getting timeout. The
398 issue was not the pull code but that fact that the idle client timeout
399 appears to be measureing to the end of the operation and the operation
400 was taking more than 40 seconds which is the default timeout. The idle
401 timeout takes no account of the fact that chunks are being regularly
402 delivered.
403 5. Several minor code changes.
404 NOTE: At this point the code passes extensive tests of the pull operations
405 both in OOP and none OOP mode (but with lots of diagnostics that may
406 be affecting timing).
|
407 karl 1.1.2.21
|
408 karl 1.1.2.20 10 April 2014
409 1. Fix issues causing failure with repeated pull operations.
410 2. Consolidate some of the CIMOperationRequestDispatcher.cpp template code
411
|
412 karl 1.1.2.19 7 April 2104
413 MergeOut of head of tree.
414
415 7 April 2014
416 1. Permanently fixed issue with getting correct number of objects on response.
417 This was introduced when did a temp fix to the OOP processing, in particular
418 removed the condition variable wait in the CIMOperationDispatcher handle
419 functions for opens and pulls. This moved the functionality to kick off
420 open and pull responses to the provider threads if there are not enough
421 objects when the handle is processed. Also added a variable to allow us to
422 test with either a) responses are required to satisfy the original
423 request size or) b, responses are required only to return some objects.
424 We will add statistics to see which of these works best.
425 2. Modified WsmProcessor EnumerationContext class since the name conflicts
426 with the pull Operation EnumerationContext class.
427 3. Created a new intermediate level of CIMMessage, the CIMPullResponseData
428 Message so that all of the open and Pull responses can use common code
429 since there are only two variables (endOfSequence and EnumerationContext)
430 and they are common across all the open and pull responses.
431 4. Removed a number of diagnostics.
432 5. Cleaned up the Dispcatcher so that the open and pulls have common response
433 karl 1.1.2.19 code and that code can be used from the dispatcher handle functions and
434 the provider response functions.
435
|
436 karl 1.1.2.18 31 March 2014 - Checkin
437 1. Fixed issues in OOP processing of pull operations, in particular
438 issues with cimxml output format when processed through the
439 *InternalXmlEncoder functions.
440 2. Clean up some of the internalXml functionality
441 3. Found issues causing timeout with a particular provider. The issue
442 is that the dispatcher and monitor end up using the same thread so the
443 condition variable in the dispatcher thread stops the monitor. Turned
444 off the conditionVariable in getCache for the moment which means that
445 we get number of responses for open... with 0 objects before the
446 providers can begin to respond. This is only for test.
447 4. Added some statistics for enumerations and display the statistics
448 when we close the server (same as cache statistics)
449
450 12 March 2014 - Mergeout and Mergein
451 1. Mergeout to head of tree for this date and mergein for patch update
452 to bug 9676
453 2. Extensions to pullop tests program and tests.
454 3. Added some diagnostics in looking for OOP issue.
455 4. Removed a number of diagnostics messages and cleaned up code in
456 dispatcher to simplify pull operation processing.
457 karl 1.1.2.18
|
458 karl 1.1.2.17 15 December 2013
459 1. Mergeout and mergein up to 15 December 2013
460 2. Clean up issues from tests documented in bug 9676 last week.
461 3. Clean up some code in dispatcher
462 4. Remove the filter function from ResponseStressc++Provider.
463
|
464 karl 1.1.2.16 21 November 2013
465 1. Mergeout from head of tree to 21 November 2013.
|
466 karl 1.1.2.15
467 18 November 2013
468 1. Cleanup of a bunch of minor errors and completion of all of the code for
469 the openQueryInstances except for the PullInstances in Dispatcher and
470 the aggregator function.
471 2. OpenqueryInstances added to cimcli.
|
472 karl 1.1.2.14
473 13 October 2013 CVS branch update.
474 1. Integrated bug 9786 into the branch. Note that we need to test the
475 generated statistics.
476 2. Mergeout executed to update to head of tree as of 8:00 am 13 October 2013.
477 3. Cleaned up several errors in OOP processing. Note that there is at least
478 one issue left when we to a pull on ManagedElement in at least one of the
479 namespaces.
480 4. Cleaned up some of the outstanding diagnostic code
481 5. Generally passes all tests except for one test of pullop where it is trying
482 to pull enum instances CIM_ManagedElement from a particular namespace.
|
483 karl 1.1.2.12
|
484 karl 1.1.2.16 NOTE: I did not make comments here for changes in October despite the fact
485 that I did 2 mergouts, number of fixes, and a mergein.
486
|
487 karl 1.1.2.12 30 September 2013 - CVS Update
488 Mergeout head of tree up to 29 September 2013.
|
489 karl 1.1.2.10
490 29 September 2013. CVS update.
491 1. Modified calls to statisticalData.cpp to a) directly call with request
492 type, b) incorporate the open, pull, etc. messages. However, since these
493 are not part of the CIM class, we must do something special with them.
|
494 karl 1.1.2.13 See bug 9785 for full solution to this issue.
|
495 karl 1.1.2.10 2. Corrected OOP interface to enable new flag to indicate internal operations
496 and set host, etc.
497 3. Add code to CQLOperationsDispatcher and WQLOperationDispatcher to clean
498 up CIMResponseDataCounter after filtering.
499 4. Modified ProviderAgent to set Host info for some pull operations.
500 5. Added new flag to CIMBinMsgSerializer and Deserializer.
|
501 karl 1.1.2.8
|
502 karl 1.1.2.9 17 September 2013 CVS update (Actually two different updates over 3 days)
503 1. Clean up some issues in CIMMessage.h and CIMMessage.cpp
504 2. Extend OpenExecQuery to WQL and CQL processors but return not complete
505 3. Remove memory leak in EnumerationContext and EnumerationContextTable
506 handling.
507 4. Created template functions for much of the pull operations.
508 5. Reversed order of queryLanguage and query (and changed names to match
509 execQuery) in client and server. Note that these are the execQuery
510 WQL and CQL filters and NOT FQL filters.
511 6. Some code cleanup in dispatcher
512 7. Today, passes all tests in pullop but issue in alltests. For some reason
513 not finding CIMObjectManager instance. Also, leaves enumeration contexts
514 if client terminates since cleanup thread not operating.
|
515 karl 1.1.2.11 8. XML from OOP not correctly processed.
|
516 karl 1.1.2.9
|
517 karl 1.1.2.8 14 September 2013 CVS update
518 Merged out up to 25 August. Cleaned up all operations and standardized code.
519 At this point the non pull operations code is in a set of templates but the
520 pull is not yet.
521 Fixed a significant number of problems so that it appears that the operations
522 except for OpenExecQuery run stably, at least with the pullop test program.
523 Note that there is a problem in that the Interop control provider is not
524 returning its singleton wbemserver object for some reason. Causes a test
525 failure
|
526 karl 1.1.2.7
527 Fixed for 16 June CVS Update
528 1. Cleaned up the enumerationContext and Table release functions and tested
529 to confirm that we do not lose memory in either normal sequences or
530 sequences that close early. Cleaned up pullop and added more tests
|
531 karl 1.1.2.8 Taged Before: PREAUG25UPDATE and after POSTAUG25UPDATE
|
532 karl 1.1.2.4
533 Fixed for 9 June CVS update
534 1. Cleaned up code for OpenQueryInstances. Note that this is incomplete.
535 No support in WQL or CQL Operations
536 2.
537
538 What was fixed for 5 June checkin.
|
539 karl 1.1.2.3 1. Extended ResponseTest MOF for for both CMPI and C++ subclasses
540 2. Fixed issues with pullop.
541 3. Fixed temp issue with CIMResponseData size by putting in mutex. That
542 is not a permanent fix but it gets around issue probably in the control
543 of the move logic that meant counts were off.
544 4. Fixed issues in Dispatcher so that associator code works. Still messy
545 code in the dispatcher.
546 5. Changed name of Enumerationtable.h & cpp to EnumerationContextTable.*
547 6 Changed name of ResponseStressTest module, classes, etc.
548
549 TAG: TASK_PEP317_5JUNE_2013_2
550
|
551 karl 1.1.2.2 2 June 2013
|
552 karl 1.1.2.1
553 Issues - KS
554
|
555 karl 1.1.2.15 - Still way to many TODO and KS comments and KS_TEMPS. Removing bit by bit.
|
556 karl 1.1.2.1
|
557 karl 1.1.2.15 - Runtime variable connection for the config parameters not installed. That
558 has been made into a separate bug (see bug 9819)
|
559 karl 1.1.2.1
560 5. Issue with the threaded timer. For some reason during tests it
561 eventually calls the timer thread with trash for the parm (which is
562 pointer to the EnumerationTable object). Caught because we do a valid
563 test at beginning of the function.
564
|
565 karl 1.1.2.2 6. Still using the templates in CIMOperationRequestDispatcher to simplify
566 the handle... processing.
567
568 7. I think I have a way around the double move of objects in the
569 EnumerationContext so that the outputter will just take a defined number
570 of objects directly from the gathering cache and save the second move.
571
|
572 karl 1.1.2.15 8. Not yet passing all tests but getting closer now. The major test that is
573 causing an error today is the execution of a full enumeration with the
574 forceProviders = true. This causes a client timeout sometimes.
|
575 karl 1.1.2.2
576
577
|
578 karl 1.1.2.1 ===========================================
579
580 OVERVIEW:
581
582 The operation extensions for pull operations defined in the DMTF specification
583 DSP0200 V 1.4 were implemented in Pegasus effective Pegasus version 2.11
584 including Client and Server.
585
586 These operations extend the CIM/XML individual operations to operation
587 sequences where the server must maintain state between operations in a
588 sequence and the client must execute multiple operations to get the full
589 set of instances or instance paths.
590
591 The following new CIM/XML operations as defined in DSP0200 are included;
592
593 -OpenEnumerateInstances
594 -openEnumerateInstancePaths
595 -OpenReferenceInstances
596 -OpenReferenceInstancePaths
597 -OpenAssociatiorInstances
598 -OpenAssociatorInstancePaths
|
599 karl 1.1.2.16 -OpenQueryInstances
|
600 karl 1.1.2.1 -PullInstancesWithPath
601 -PullInstancePaths
|
602 karl 1.1.2.16 -PullInstances
|
603 karl 1.1.2.1 -CloseEnumeration
604 -EnumerationCount
|
605 karl 1.1.2.2 OpenExecQuery
|
606 karl 1.1.2.1
607 The following operations have not been implemented in this version of Pegasus:
608
609 -OpenQueryInstances
610
611 The following limitations on the implementation exist;
612
613 1. The filterQueryLanguage and filterQuery parameters are processed by
614 the Pegasus client but the server returns error if there is any data in
|
615 karl 1.1.2.2 either parameter. This work does not include the development of the
616 query language. Note that a separate effort to extend Pegasus to use
617 the DMTF FQL query language is in process.
|
618 karl 1.1.2.1
619 2. The input parameter continueOnError is processed correctly by the client
620 but the Pegasus server only provides for false since the server does not
621 include logic to continue processing responses after an error is
622 encountered.
623 This is consistent with the statement in the specification that use of
624 this functionality is optional and the fact that the DMTF agrees that all
625 of the issues of continuing after errors have not been clarified.
626
627 3. The operation enumerationCount is not processed by the server today since
628 a) really getting the count would be the same cost as the corresponding
629 enumeration, b) the server does not include a history or estimating
630 mechanism for this to date.
|
631 karl 1.1.2.2 NOTE: After a through review as part of the development of the next version
632 of CMPI we have concluded that this operation is probably not worth the
633 effort. Since it is optional, Pegasus will only return the unknown status
634 at this point
|
635 karl 1.1.2.1
636 Since the concept of sequences of operations linked together (open, pull, close)
637 is a major extension to the original CIM/XML operation concept of completely
638 independent operations several new pieces of functionality are implemented
639 to control interOperationTimeouts, counts of objects to be returned, etc.
640
641 TBD - Review this
642
643 CLIENT
644
645 The new operations follow the same pattern as the APIs for existing operations
646 in that:
647
648 1. All errors are handled as CIMException and Exception
649
650 2. The means of inputting parameters are the same except that there are
651 significantly more input parameters with the open operations and for the
652 first time operations return parameters as well as objects in the
653 response. Specifically the open and pull operations return values for
654 enumerationContext which is the identity for a pull sequence and
655 endOfSequence which is the marker the server sends in open and pull
656 karl 1.1.2.1 responses when it has no more objects to send.
657
658 The significant differences include:
659
660 1. Processing of parameters on responses (i.e. the endOfSequence and
661 enumerationContext parameters are returned for open and pull operations).
662
663 2. Numeric arguments (Uint32 and Uint64 include the option of NULL in some
664 cases so they are packaged inside classes Uint32Arg and Uint64Arg in the
665 client api.
666
667 3. The association and reference operations ONLY process instances. They do
668 not include the capability to return classes like reference and associator
669 do and therefore return CIMInstance rather than CIMObject.
670
671 4. Paths are returned in all cases (i.e OpenEnumerateInstances and
672 PullInstancesWithPath where they were not with EnumeratInstances.
673
674 5. The client must maintain state between operations in a sequence (using
675 the enumerationContext parameter).
676
677 karl 1.1.2.1 TBD- Are there more differences.
678
679
680 SERVER
681
682 The Pegasus server attempts to always deliver the requested number of objects
683 for any open or pull request (the specification allows for the server to
684 deliver less than the requested number of objects and specifically to return
685 zero objects on open). We felt that it was worth any extra cost in processing
686 to provide the client with exactly what it had requested.
687
688 The pegasus server always closes an enumeration sequence upon receipt of any
689 error from the providers, repository, etc. Therefore the server will reject
|
690 karl 1.1.2.2 any request that has continueOnError = true;
691
692 Expansion to allow the continue on error may be added in a future version.
693 In any case, the whole purpose of the continue on error is really to allow
694 input from good providers to be mixed with providers that return errors so
695 that generally this would mean simply changing the logic in the return mechanism
696 to not shutdown when an error is received from any given provider.
697
698 Generally we do not believe that the providers need to do much more in the
699 future to support the continueOnError other than possibly allowing the provider
700 to continue processing after it has received an error.
|
701 karl 1.1.2.1
702 PROVIDERS
703
704 This implementation requires NO changes to the existing providers. The
705 provider APIs operate just as they do with the original operations.
706
707 Because the server processing is different however, there may be some
708 behavior differences primarily because the client now controls the speed of
709 delivery of objects.
710
711 In previous versions of Pegasus, the server attempts to deliver objects as
712 rapidly as then can be put on the network. In the case of HTTP chunked requests
713 they are delivered in chunks of about 100 objects. The primary delay for the
714 providers was the processing of each segment through the server. The server
715 is blocked so that no other segment can proceed through the server until that
716 segment is processed and sent on the network.
717 In the case of non-chunkedresponses, they are completely gathered in the serve
718 and then delivered as one non-chunked response. There were no delays for the
719 providers, just lots of possible memory use in the server.
720
721 The responses from providers (delivered through the deliver(...) interface are
722 karl 1.1.2.1 gathered into segments of about 100 objects and this group of objects is moved
723 through the server to be delivered to the client.
724
725 However with the inclusion of the pull operations, The segments of objects
726 from the providers are cached in the server response path until the
727 maxObjectCount for that request (open or pull) and that number returned in a
728 non-chunked response. Thus, if the client is slow to issue pull requests,
729 the providers might be delayed at some point to reduce memory usage in the
730 server (the delay appears as slow response tothe deliver operation).
731
732 In other words, the time to process large sets of responses from the provider
733 now depends on the speed of handling the client.
734
735 It is important to remember in developing providers that the Pegasus server
736 can most efficiently process responses if they are passed from the provider
737 to the server individually or in small arrays of objects rather than the
738 provider gathering very large arrays of objects and sending them to the
739 server.
740
|
741 karl 1.1.2.2 NEXT GENERATION PROVIDERS
742 KS_TODO
743
|
744 karl 1.1.2.1 CONFIGURATION PARAMETERS
745
746 The server includes several configuration parameters to set limits on the
747 processing of pull operations. All of these configuration parameters are
748 compile time parameters rather than runtime.
749
750 1. Maximum value of minimum interoperation time. This parameter defines the
751 maximum time allowed between the return of an open or pull response and
752 the receipt of the next pull or a close operation before the server may
753 close the enumeration. The specification allows the server to set a
754 maximum interoperation time and refuse open requests that with requested
755 operationTimeout greater than that time.
756 CIM_ERR_INVALID_OPERATION_TIMEOUT
757
758 This value is set with the Pegasus environment variable
759 PEGASUS_PULL....
760
761 2. Maximum objects returned in a single open or pull operation. The server
762 can set a maximum limit on the number of objects that can be returned in
763 a single open or pull oepration with the maxObjectCount parameter.
764
765 karl 1.1.2.1 3. Whether the server allows 0 as an interoperation timeout value. The value
766 zero is s special value for the interoperationTimeout in that it tells the
767 server to not timeout any enumeration sequence.
768
769 With this value for interoperationTimeout, the only way to close an
770 enumeration sequence is to complete all of the pulls or issue the close.
771 If for some reason the sequence is not completed, that enumeration context
772 would remain open indefinitly. Since in Pegasus any open enumeration
773 context uses resources (the context object and any provider resposnes that
774 have not yet been issued in a response) it would appear that most
775 platforms would not want to allow the existence of enumeration contexts
776 that cannot be closed by the server.
777
778 4, maximum consecutive pull requests with 0 maxObjectCount. The use of the
779 pull operation with maxObjectCount set to zero could be used to keep an
780 enumeration context open indefinitly (this tells the server to restart the
781 interoperationTimeout but not send any objects in the response). Therefore the
782 specification allows for the server setting maximum limits on this behavior
783 and returning the error CIM_ERR_SERVER_LIMITS_EXCEEDED if this limit is
784 exceeded.
785 Note that this is maximum CONSECUTIVE pulls so that issuing a pull with
786 karl 1.1.2.1 a non-zero count resets this counter.
787
788 KS-TBD - Is this really logical since we can still block by just issuing
789 lots of zero request and an occansional request for one object.
790
791 Pegaus sets the value of this limit to 1000 and allows the implementer to
792 modify it with the PEGASUS_MAXIMUM_ZERO_OBJECTCOUNT environment variable.
793
794 5. Default operationTimeout -
795
796 The default of this parameter is to refuse operat
797
798 In the current release of Pegasus these are all compile time parameters.
|
799 karl 1.1.2.11
800
801 NOTES On working with task branch.
802
803 Merge out Process
804
805 To keep our TASK branch in sync with the current head of tree we need
806 to do a regular merge out. the TaskMakefile contains the makefile
807 procedures to do this efficiently. NOTE: Following these procedures is
808 important in that you are merging out new material each time you do
809 the merge out. If you were just to repeatedly merge out, you would be
810 merging previously merged changes a second time causing a real mess.
811
812 Start with new directory and put TaskMakefile above pegasus (needed so you
813 have this file for the initial operations.
814
815 make -f TaskMakefile branch_merge_out BNAME=PEP317-pullop ## takes a long time
816
817 This checks out current head, merges it into task branch and sets tags
818 for the mergeout. Note that at the end of this step this work is
819 part of the TASK... branch.
820 karl 1.1.2.11
821 NOW check for conflicts, errors, etc. that resulted from the merge.
822 Look for conflict flags, compare the results (I use linux merge as a
823 good graphic compare tool) and build and test. When you are satisfied
824 that the merge out is clean, you can commit the results to the TASK...
825 branch
826
827 To commit the work to this into Task branch
828
829 make -f mak/TaskMakefile branch_merge_out_commit BNAME=PEP317-pullop
830
831 or manually commit and finish as follows
832
833 cvs commit
834 make -f mak/TaskMakefile branch_merge_out_finish BNAME=PEP317-pullop
835
836 ## This last step is important since it cleans up temporary tags to prepare
837 you for the next checkout
838
839 COMPARE TASKBRANCH WITH HEAD
840
841 karl 1.1.2.11 In a new pegasus work space do same as above for merge out.
842
843 make -f TaskMakefile BNAME=PEP317-pullop
844
845 This produces a result which is all of the head merged into the branch.
846 A diff of this is all the new changes to the head of tree that you will
847 include into the merge.
848
|
Return to
readme.pulloperations
CVS log
Up to [Pegasus] / pegasus