pegasus/readme.pulloperations - diff

Return to readme.pulloperations CVS log

Up to [Pegasus] / pegasus

Diff for /pegasus/readme.pulloperations between version 1.1.2.1 and 1.1.2.7

version 1.1.2.1, 2011/01/16 21:11:30

version 1.1.2.7, 2013/06/16 13:04:23

Line 2

STATUS

<<< This section is being maintained during the review and checkin process

<<< The TODO section is being maintained during the review and checkin process

to keep track of problems, errors, notes, etc. Must be deleted before

checkin to head of tree. Please feel free to add notes, etc in this

section as you review/test.>>>>>>

16 Jan 2011

NOTES On working with task branch.

Merge out Process

To keep our TASK branch in sync with the current head of tree we need

to do a regular merge out. the TaskMakefile contains the makefile

procedures to do this efficiently. NOTE: Following these procedures is

important in that you are merging out new material each time you do

the merge out. If you were just to repeatedly merge out, you would be

merging previously merged changes a second time causing a real mess.

Start with new directory and put TaskMakefile above pegasus (needed so you

have this file for the initial operations.

make -f TaskMakefile branch_merge_out BNAME=PEP317-pullop ## takes a long time

This checks out current head, merges it into task branch and sets tags

for the mergeout. Note that at the end of this step this work is

part of the TASK... branch.

NOW check for conflicts, errors, etc. that resulted from the merge.

Look for conflict flags, compare the results (I use linux merge as a

good graphic compare tool) and build and test. When you are satisfied

that the merge out is clean, you can commit the results to the TASK...

branch

To commit the work to this into Task branch

make -f mak/TaskMakefile branch_merge_out_commit BNAME=PEP317-pullop

or manually commit and finish as follows

cvs commit

make -f mak/TaskMakefile branch_merge_out_finish BNAME=PEP317-pullop

## This last step is important since it cleans up temporary tags to prepare

you for the next checkout

COMPARE TASKBRANCH WITH HEAD

In a new pegasus work space do same as above for merge out.

make -f TaskMakefile BNAME=PEP317-pullop

This produces a result which is all of the head merged into the branch.

A diff of this is all the new changes to the head of tree that you will

include into the merge.

TODO list:

1. Binary operation from OOP. Need to add counter to binary

protocol to be able to count objects in response. Generates

warnings in things like messageserializer and does not work with

OOP right now.

2. OpenExecQuery - Code is incorrect in that it used InstancesWithPath

where the spec is instances with no path. Need new function to wrap

getInstanceElement(withoutPathElement) in XmlReader. Note that

Alternate is to put flag on InstancesWith Path to say no path

3. Code for Pull part of OpenQueryInstancesRequest a) should be part of

the common CIMOperationRequestDispatcher execCommon code.

4. The changes to WQLCIMOperationRequestDispatcher and CQL... for handling

pull not completed so we feed the responses back to the EnmerationContext

queues

3. Lots of minor TODOs, diagnostics, etc.

4. External runtime variables. Decide this as part of PEP. The variables

exist in CIMOperationRequestDispatcher but not in CIMConfig. The primary

ones to consider are:

a. System maxObjectCount. Setting some maximum size on what a pull

client can request (i.e. the maximum size of the maxObjectCount on

Open... and pull operations.

b. Pull interoperationTimeout (max times between operations). This is

the maximum number of seconds on the operationTimeout parameter of the

Open operations

c. Maximum size of the responseCache before it starts backing up

responses to the providers.

5. Decision on EnumerationContext timeout (separate thread or just

checks during other operations). Can we, in fact really keep the

enumeration context table and queue under control without monitoring

with a separate thread. We must monitor for:

a. Client operation that stop requesting (i.e. inter operation time

exceeds operationTimeout). Note that if it simply exceeds the time

the next operation does the cleanup. The issue is those clients that

simply stop and do not either close or go to completion.

b. We should protect against providers that no not every finish delivering

or take to long between deliveries. This does not exist in Pegasus

today

6. Clean up code in Dispatcher. The associators code is still real mess

and the pull code is in a template. The Pull code is good now but

must be duplicated. Look at creating new CIMMessage CIMPullResponseMessage

so that we can have common code. Everything is the same except what

goes into the CIMResponseData so it is logical to have completely

common processing

7. Extension to avoid double move of objects in CIMResponseData (one

into enumerationContext queue and second to new cimResponseData for

response. Want to avoid second move by extending Open/Pull response

messages to include count and CIMResponse data to count objects out

of queue when converting (avoids the second move). Big issue here

with binary data since need to extend format to count it.

8. Still using templates, etc. in code in the Dispatcher. This is for

all of the open operations where there is a lot of duplicate code

and the pull operations that are 99% duplicate code (in a single template)

9. NEXT TASK: get the pull operations into a single function by

creating a new CIMPullResponse message in CIMMessage.h that contains

the pull data. Then we can use a single function to process all pull

operations.

Fixed for 16 June CVS Update

1. Cleaned up the enumerationContext and Table release functions and tested

to confirm that we do not lose memory in either normal sequences or

sequences that close early. Cleaned up pullop and added more tests

Fixed for 9 June CVS update

1. Cleaned up code for OpenQueryInstances. Note that this is incomplete.

No support in WQL or CQL Operations

What was fixed for 5 June checkin.

1. Extended ResponseTest MOF for for both CMPI and C++ subclasses

2. Fixed issues with pullop.

3. Fixed temp issue with CIMResponseData size by putting in mutex. That

is not a permanent fix but it gets around issue probably in the control

of the move logic that meant counts were off.

4. Fixed issues in Dispatcher so that associator code works. Still messy

code in the dispatcher.

5. Changed name of Enumerationtable.h & cpp to EnumerationContextTable.*

6 Changed name of ResponseStressTest module, classes, etc.

TAG: TASK_PEP317_5JUNE_2013_2

2 June 2013

Issues - KS

1. have not installed the binary move in CIMResponseData. Please run

Line 25

Line 154

pointer to the EnumerationTable object). Caught because we do a valid

test at beginning of the function.

6. Still using the templates in CIMOperationRequestDispatcher to simplify

the handle... processing.

7. I think I have a way around the double move of objects in the

EnumerationContext so that the outputter will just take a defined number

of objects directly from the gathering cache and save the second move.

8. Not yet passing all tests but getting closer now.

9. Created a tag before this commit TASK_PEP317_1JUNE_2013.

10. Next Tag will be TASK_PEP317_2_JUNE_2013 in the task branch

===========================================

OVERVIEW:

Line 50

Line 193

-PullInstancePaths

-CloseEnumeration

-EnumerationCount

OpenExecQuery

The following operations have not been implemented in this version of Pegasus:

Line 59

Line 203

1. The filterQueryLanguage and filterQuery parameters are processed by

the Pegasus client but the server returns error if there is any data in

either parameter. This is because the definition of query language has not

either parameter. This work does not include the development of the

been clarified to date by the DMTF.

query language. Note that a separate effort to extend Pegasus to use

the DMTF FQL query language is in process.

2. The input parameter continueOnError is processed correctly by the client

but the Pegasus server only provides for false since the server does not

Line 74

Line 219

a) really getting the count would be the same cost as the corresponding

enumeration, b) the server does not include a history or estimating

mechanism for this to date.

KS_TBD_ confirm this

NOTE: After a through review as part of the development of the next version

of CMPI we have concluded that this operation is probably not worth the

effort. Since it is optional, Pegasus will only return the unknown status

at this point

Since the concept of sequences of operations linked together (open, pull, close)

is a major extension to the original CIM/XML operation concept of completely

Line 128

Line 276

zero objects on open). We felt that it was worth any extra cost in processing

to provide the client with exactly what it had requested.

continueOnError Parameter

The pegasus server always closes an enumeration sequence upon receipt of any

error from the providers, repository, etc. Therefore the server will reject

and request that has continueOnError = true;

any request that has continueOnError = true;

Expansion to allow the continue on error may be added in a future version.

In any case, the whole purpose of the continue on error is really to allow

input from good providers to be mixed with providers that return errors so

that generally this would mean simply changing the logic in the return mechanism

to not shutdown when an error is received from any given provider.

Generally we do not believe that the providers need to do much more in the

future to support the continueOnError other than possibly allowing the provider

to continue processing after it has received an error.

PROVIDERS

Line 172

Line 329

provider gathering very large arrays of objects and sending them to the

server.

NEXT GENERATION PROVIDERS

KS_TODO

CONFIGURATION PARAMETERS

The server includes several configuration parameters to set limits on the

Legend:

Removed from v.1.1.2.1
changed lines
	Added in v.1.1.2.7

No CVS admin address has been configured