pegasus/readme.pulloperations - diff

Return to readme.pulloperations CVS log

Up to [Pegasus] / pegasus

Diff for /pegasus/readme.pulloperations between version 1.1.2.24 and 1.1.2.32

version 1.1.2.24, 2014/04/22 23:51:39

version 1.1.2.32, 2014/05/26 18:46:21

Line 11

1. Binary operation from OOP. Need to add counter to binary

protocol to be able to count objects in response. Generates

warnings in things like messageserializer and does not work with

OOP right now. Corrected by converting to XML.

OOP right now. Fixed by converting to XML. Concluded that we do not

need to do this. The binary response is not really used often

in the current environment So double mapping it is not a major issue.

Leave this as FUTURE

2. OpenExecQuery - Code is incomplete in that it does not include the

return from the exec query function to the aggregator yet.

return from the exec query function to the aggregator yet. Code for Pull

3. Code for Pull part of OpenQueryInstancesRequest a) should be part of

part of OpenQueryInstancesRequest a) should be part of

the common CIMOperationRequestDispatcher execCommon code.

4. The changes to WQLCIMOperationRequestDispatcher and CQL... for handling

3. The changes to WQLCIMOperationRequestDispatcher and CQL... for handling

pull not completed so we feed the responses back to the EnmerationContext

queues

3. Lots of minor TODOs, diagnostics, etc. still in the code

4. Minor TODOs, diagnostics, etc. still in the code

4. External runtime variables. Proposing that they be fixed for this release

5. Extension to avoid double move of objects in CIMResponseData (one

rather than set by configuration. This should be discussed. Am making

this a separate bug. See bug 9819 for the changes to cover this.

5. Consider moving some more of the code in dispatcher from templates to

common functions which would mean adding intermediate classes in

CIMMessage but would reduce code size. Currently the change that

we should make for this is to create a new message CIMPullRequestData...

between CIMRequestDataMessage and the Pull requests since they all

have exactly the same input and output pararameters (The

CIMResponseData hides the response object differences)

6. Extension to avoid double move of objects in CIMResponseData (one

into enumerationContext queue and second to new cimResponseData for

response. Want to avoid second move by extending Open/Pull response

messages to include count and CIMResponse data to count objects out

of queue when converting (avoids the second move). This would mean

extending the output writers to allow the count field to be supplied

so they would only create output for up to the count supplied.

so they would only create output for up to the count supplied.(Make

7. Add test for the 0 operation timeout in PullErrors.

this future beyond bug 9676)

8. Add more static tests (currently only OpenEnumerateInstances is covered).

6. Add more static tests (currently only OpenEnumerateInstances and

9. Could clean up the CIMOperationRequestDecoder.cpp rejectCIMException

OpenEnumerateInstanceNames covered).

further since there is some overlap. That is low priority.

Low priority because most of this except exact XML covered in other

10.Add exception for to many entries in EnumerationContextTable. The

tests. note that we can only add very limited tests since a) no

test exists but is ignored right now.

way to test multiple operations in sequence(i.e. open/pull) and

7. NEXT TASKS:

cannot be sure how many responses will come back in all cases even

b. Finish and test the OpenQueryInstances

for open.

c. Clean up TODOs

7. Clean up the CIMOperationRequestDecoder.cpp rejectCIMException

d. Find issue that is causing occasional failures under load. It

further since there is some overlap. VERY Low priority.

is probably a threading issue between the 3 possible threads

8. Correct issue between operations and HTTP where we are sending

that use the EnumerationContext (request thread, provider thread,

trailers with exceptions. Modify response mechanisms so that we

timeout thread) and a place where not mutuxed, primarily the

set non-chunked for all responses where we send error responses to

timeout thread.

avoid the trailers.

9. It would be more efficient in dispatcher to always use exception for

rejects and change the _reject functions so that they never return

when they reject. This is VERY LOW PRIORITY and primarily saves

a few lines of code in the reject functions and their calls. Means we

would code.

_rejectIfEnumerationToBroad(...)

_rejectIfThisParameterIncorrect(...)

instead of

if (_rejectIfEnum...)

{

return true

}

It would mean that the method trace for the handlers would not return

an exit if we rejected. LOW PRIORITY

10. There are still a couple of template functionsaround the task of

distributing requests to the multiple providers.

In fact there are two similiar but different templates for

the associators(i.e. assoc, ref, etc.) functions and the parallel

openAssoc functions. It would be nice to consolidate that logic and

further to try to create a non-template form for those functions. LOW

PRIORITY.

11. External runtime variables. Proposing that they be fixed for this release

rather than set by configuration. Making this a separate bug.

See bug 9819 for the changes to cover this.

NEXT TASKS:

a. finish 8, 11 3 above

26 May 2014

1. Remove a number of diagnostics.

2. Make cache size in EnumerationContextTable dynamic and remove function

to set default values. MaximumEnums set from Dispatcher on constructor for

EnumerationContextTable and table size set to 1/2 of maximum number of

open contexts.

3. Clean up some statistics in EnumerationContextTable

9 May 2104

1. Converted several template functions in CIMOperationRequestDispatcher

to real functions

2. Added intermediate CIMMessage for CIMPullOperationRequestMessage since

all of the pulls have exactly the same data. This allowed us to

convert the template function processPullRequest from template to

real function

3. Added intermediate CIMMessage for CIMOpenOperationRequestMessage betweeh\n

all of the Opens and the CIMRequestData message. This will allow

common code to test all of these variables in all 6

CIMOperationRequestDispatcher handleOpen... functions

3. Added variable in CIMOperationRequestDispatcher handleEnqueue to make

releasing the original request conditional on return from the handle...

for open... and pull... handlers.

This allowed us to drop one place where we were creating a new request msg

for the delayed response and use the original request. This meant that

we could convert the issueOpenOrPullResponse from template function to

real function.

4. Moved open and pull constructors in CIMMessage.h to CIMMessage.cpp. NOTE:

openQueryInstances not moved. Will do when we get this funciton running.

5. Added test for correct namespace in pull operations. Note that it is

never really used but since supplied with request, we test to be sure it is

same as open request namespace. added internationalized exception for this.

6. We should probably add same test to close just as an input parameter

validation.

6. Modified processPullRequest to close the enumeration context if

incorrect response type received. Before we just returned exception and

left context open for next request. Closing is much more logical since the

client really did send an erronous request.

7. Modified PullErrors to correctly test above changed in behavior.

8. Removed a significant number of diagnostic messages.

4 May 2014

1. Clean interface with EnumerationContext timeout thread

2. Remove more diagnostics

3. Correct issue with enumerationContext Release that was causing

failures during nightly tests.

2 May 2014

1. Remove Diagnostics from ResponseData.cpp

2. Correct setup and start of EnumerationContextTimerThread

3. Change limit on max number of enum contexts to be set from Dispatcher.

4. Increase size of hashtable for enum contexts.

5. Corrected issue causing failures in removeContext. Now runs through nightly

tests most of the time.

1 May 2014

1. Cleanup of code and variable names.

2. Removed namespace variable from EnumerationContext. It was never used.

3. Added test for max number of open enumerations. Right now it is fixed

and set about 100. Note that this is tied to the size of hash table

so that there is a issue with more dynamic setting of max and the

hash table size.

4. Removed several unused functions.

5. Found one possible issue causing thread conflict but not the core one

yet.

30 April

1. Added exception response to dispatcher for Limits exceeded on

CreateEnumerationContext. Returns Exceeded server limits CIMException.

2. Fixed possible deadlock where we were not unlocking EnumerationContext

under error condition

27 April - mergeout to head of tree

1. Mergeout of the code to the head of tree. Documented that mergeout in

the bug

27 April 2014

1. Clean up in a number of areas, mostly just code without changing

functionality.

2. Modified CIMMessage.h slightly to clarify names of the pull intermediate

messages (the common open and pull response);

3. Removed a number of diagnostics from CIMResponseData

4. Added new function to ResponseStressTestProvider to be able to terminate

output after a defined number of objects with a CIMException.

5. Removed a number of other TODOs

6. Corrected a couple of errors in the server message bundle.

7. Modified ResponseEncoder to only output the error for pull errors.

It was errounously outputting the EndOfSequence, EnumerationContext and

the error. This way, only the error is sent which is spec.

8. Removed number of TODOs and cleaned up a couple of others.

9. Added static tests for OpenEnumerateInstanceNames.

10. Modified a number of the temporary diagnostics to be permanent by

changing them to PEGASUS_DEBUG_ASSERTs

22 April 2014

1. Clean up some messages.

2. Still trying to find issue that randomly keeps messages in timeout

queue long after they have been closed and returned.

3. Fixed memory loss error.

4. Added zero reject for OperationTimeout because that effectively disables

the whole timeout mechanism so that enumerations could be started, never

completed by the client and would just hang around in memory. That

would be a significant DDOS attack (start very large enum with no

timeout) and never do pulls after open.

21 April 2014

1. Reorganizzed code in CIMOperationRequestDecoder.cpp ...Iparam classes.

1. Reorganized code in CIMOperationRequestDecoder.cpp ...Iparam classes.

Cleaned up the rejectCIMException code.

2. Cleanup some issues in the EnumerationContextTimeout Thread.

3. Fixed issue in pullop where it was using zero as default for default

Legend:

Removed from v.1.1.2.24
changed lines
	Added in v.1.1.2.32

No CVS admin address has been configured