pegasus/readme.pulloperations - diff

Return to readme.pulloperations CVS log

Up to [Pegasus] / pegasus

Diff for /pegasus/readme.pulloperations between version 1.1.2.5 and 1.1.2.31

version 1.1.2.5, 2013/06/11 23:17:40

version 1.1.2.31, 2014/05/09 16:46:15

Line 7

checkin to head of tree. Please feel free to add notes, etc in this

section as you review/test.>>>>>>

NOTES On working with task branch.

Merge out

I just start with new directory and put TaskMakefile above pegasus

make -f TaskMakefile BNAME=PEP317-pullop ## takes a long time

checks out current head, merges it into task branch and sets tags

NOW check for conflicts, errors, etc.

To check this into Task branch

make -f mak/TaskMakefile branch_merge_out_commit BNAME=PEP317-pullop

or manually commit and finish as follows

cvs commit

make -f mak/TaskMakefile branch_merge_out_finish BNAME=PEP317-pullop

## This last step is important since it cleans up temporary tags.

COMPARE TASKBRANCH WITH HEAD

In a new pegasus work space do same as for merge out.

make -f TaskMakefile BNAME=PEP317-pullop

This produces a result which is all of the head merged into the branch.

A diff of this is all the new changes to the head of tree.

TODO list:

1. Binary operation from OOP. Need to add counter to binary

protocol to be able to count objects in response. Generates

warnings in things like messageserializer and does not work with

OOP right now.

OOP right now. Fixed by converting to XML. Concluded that we do not

2. OpenExecQuery - Code is incorrect in that it used InstancesWithPath

need to do this. The binary response is not really used often

where the spec is instances with no path. Need new function to wrap

in the current environment So double mapping it is not a major issue.

getInstanceElement(withoutPathElement) in XmlReader. Note that

Leave this as FUTURE

Alternate is to put flag on InstancesWith Path to say no path

2. OpenExecQuery - Code is incomplete in that it does not include the

3. Code for Pull part of OpenQueryInstancesRequest a) should be part of

return from the exec query function to the aggregator yet. Code for Pull

part of OpenQueryInstancesRequest a) should be part of

the common CIMOperationRequestDispatcher execCommon code.

4. The changes to WQLCIMOperationRequestDispatcher and CQL... for handling

3. The changes to WQLCIMOperationRequestDispatcher and CQL... for handling

pull not completed so we feed the responses back to the EnmerationContext

queues

3. Lots of minor TODOs, etc.

4. Minor TODOs, diagnostics, etc. still in the code

4. External runtime variables. Decide this as part of PEP. The variables

5. Extension to avoid double move of objects in CIMResponseData (one

exist in CIMOperationRequestDispatcher but not in CIMConfig. The primary

ones to consider are:

a. System maxObjectCount. Setting some maximum size on what a pull

client can request (i.e. the maximum size of the maxObjectCount on

Open... and pull operations.

b. Pull interoperationTimeout (max times between operations). This is

the maximum number of seconds on the operationTimeout parameter of the

Open operations

c. Maximum size of the responseCache before it starts backing up

responses to the providers.

5. Decision on EnumerationContext timeout (separate thread or just

checks during other operations). Can we, in fact really keep the

enumeration context table and queue under control without monitoring

with a separate thread. We must monitor for:

a. Client operation that stop requesting (i.e. inter operation time

exceeds operationTimeout). Note that if it simply exceeds the time

the next operation does the cleanup. The issue is those clients that

simply stop and do not either close or go to completion.

b. We should protect against providers that no not every finish delivering

or take to long between deliveries. This does not exist in Pegasus

today

6. Clean up code in Dispatcher. The associators code is still real mess

and the pull code is in a template. The Pull code is good now but

must be duplicated. Look at creating new CIMMessage CIMPullResponseMessage

so that we can have common code. Everything is the same except what

goes into the CIMResponseData so it is logical to have completely

common processing

7. Extension to avoid double move of objects in CIMResponseData (one

into enumerationContext queue and second to new cimResponseData for

response. Want to avoid second move by extending Open/Pull response

messages to include count and CIMResponse data to count objects out

of queue when converting (avoids the second move). Big issue here

of queue when converting (avoids the second move). This would mean

with binary data since need to extend format to count it.

extending the output writers to allow the count field to be supplied

8. Still using templates, etc. in code in the Dispatcher. This is for

so they would only create output for up to the count supplied.(Make

all of the open operations where there is a lot of duplicate code

this future beyond bug 9676)

and the pull operations that are 99% duplicate code (in a single template)

6. Add more static tests (currently only OpenEnumerateInstances and

OpenEnumerateInstanceNames covered).

Low priority because most of this except exact XML covered in other

tests. note that we can only add very limited tests since a) no

way to test multiple operations in sequence(i.e. open/pull) and

cannot be sure how many responses will come back in all cases even

for open.

7. Could clean up the CIMOperationRequestDecoder.cpp rejectCIMException

further since there is some overlap. VERY Low priority.

8. Make enumContextTable hashtable dynamic and create entirely within

CIMOperationRequestDispatcher.cpp. Today it has a static size

9. Correct issue between operations and HTTP where we are sending

trailers with exceptions. Modify response mechanisms so that we

set non-chunked for all responses where we send error responses to

avoid the trailers.

10. It would be more efficient in dispatcher to always use exception for

rejects and change the _reject functions so that they never return

when they reject. This is VERY LOW PRIORITY and primarily saves

a few lines of code in the reject functions and their calls. Means we

would code.

_rejectIfEnumerationToBroad(...)

_rejectIfThisParameterIncorrect(...)

instead of

if (_rejectIfEnum...)

{

return true

}

It would mean that the method trace for the handlers would not return

an exit if we rejected. LOW PRIORITY

11. We have reduced the number of template function greatly. However there

are still several around the task of distributing requests to the

multiple providers. In fact there are two similiar but different for

the associators(i.e. assoc, ref, etc.) functions and the parallel

openAssoc functions. It would be nice to consolidate that logic and

further to try to create a non-template form for those functions. LOW

PRIORITY.

13. External runtime variables. Proposing that they be fixed for this release

rather than set by configuration. Making this a separate bug.

See bug 9819 for the changes to cover this.

NEXT TASKS:

a. finish 8, 9 3 above

9 May 2104

1. Converted several template functions in CIMOperationRequestDispatcher

to real functions

2. Added intermediate CIMMessage for CIMPullOperationRequestMessage since

all of the pulls have exactly the same data. This allowed us to

convert the template function processPullRequest from template to

real function

3. Added intermediate CIMMessage for CIMOpenOperationRequestMessage betweeh\n

all of the Opens and the CIMRequestData message. This will allow

common code to test all of these variables in all 6

CIMOperationRequestDispatcher handleOpen... functions

3. Added variable in CIMOperationRequestDispatcher handleEnqueue to make

releasing the original request conditional on return from the handle...

for open... and pull... handlers.

This allowed us to drop one place where we were creating a new request msg

for the delayed response and use the original request. This meant that

we could convert the issueOpenOrPullResponse from template function to

real function.

4. Moved open and pull constructors in CIMMessage.h to CIMMessage.cpp. NOTE:

openQueryInstances not moved. Will do when we get this funciton running.

5. Added test for correct namespace in pull operations. Note that it is

never really used but since supplied with request, we test to be sure it is

same as open request namespace. added internationalized exception for this.

6. We should probably add same test to close just as an input parameter

validation.

6. Modified processPullRequest to close the enumeration context if

incorrect response type received. Before we just returned exception and

left context open for next request. Closing is much more logical since the

client really did send an erronous request.

7. Modified PullErrors to correctly test above changed in behavior.

8. Removed a significant number of diagnostic messages.

4 May 2014

1. Clean interface with EnumerationContext timeout thread

2. Remove more diagnostics

3. Correct issue with enumerationContext Release that was causing

failures during nightly tests.

2 May 2014

1. Remove Diagnostics from ResponseData.cpp

2. Correct setup and start of EnumerationContextTimerThread

3. Change limit on max number of enum contexts to be set from Dispatcher.

4. Increase size of hashtable for enum contexts.

5. Corrected issue causing failures in removeContext. Now runs through nightly

tests most of the time.

1 May 2014

1. Cleanup of code and variable names.

2. Removed namespace variable from EnumerationContext. It was never used.

3. Added test for max number of open enumerations. Right now it is fixed

and set about 100. Note that this is tied to the size of hash table

so that there is a issue with more dynamic setting of max and the

hash table size.

4. Removed several unused functions.

5. Found one possible issue causing thread conflict but not the core one

yet.

30 April

1. Added exception response to dispatcher for Limits exceeded on

CreateEnumerationContext. Returns Exceeded server limits CIMException.

2. Fixed possible deadlock where we were not unlocking EnumerationContext

under error condition

27 April - mergeout to head of tree

1. Mergeout of the code to the head of tree. Documented that mergeout in

the bug

27 April 2014

1. Clean up in a number of areas, mostly just code without changing

functionality.

2. Modified CIMMessage.h slightly to clarify names of the pull intermediate

messages (the common open and pull response);

3. Removed a number of diagnostics from CIMResponseData

4. Added new function to ResponseStressTestProvider to be able to terminate

output after a defined number of objects with a CIMException.

5. Removed a number of other TODOs

6. Corrected a couple of errors in the server message bundle.

7. Modified ResponseEncoder to only output the error for pull errors.

It was errounously outputting the EndOfSequence, EnumerationContext and

the error. This way, only the error is sent which is spec.

8. Removed number of TODOs and cleaned up a couple of others.

9. Added static tests for OpenEnumerateInstanceNames.

10. Modified a number of the temporary diagnostics to be permanent by

changing them to PEGASUS_DEBUG_ASSERTs

22 April 2014

1. Clean up some messages.

2. Still trying to find issue that randomly keeps messages in timeout

queue long after they have been closed and returned.

3. Fixed memory loss error.

4. Added zero reject for OperationTimeout because that effectively disables

the whole timeout mechanism so that enumerations could be started, never

completed by the client and would just hang around in memory. That

would be a significant DDOS attack (start very large enum with no

timeout) and never do pulls after open.

21 April 2014

1. Reorganized code in CIMOperationRequestDecoder.cpp ...Iparam classes.

Cleaned up the rejectCIMException code.

2. Cleanup some issues in the EnumerationContextTimeout Thread.

3. Fixed issue in pullop where it was using zero as default for default

operation timeout where it should have been NULL, the DMTF specified

default.

4. Enabled the test to reject 0 as operation timeout on a request and but

controled by a #define in CIMOperationRequestDispatcher.cpp

5. Added test for excessive new OperationContext entries in table.

18 April 2014

1. Internationalize remaining messages in CIMOperationRequestDecoder.cpp and

clean up the decoders for some of the messages so they use the

...Iparam classes. Note that we did not clean up all of the old message

decoders, just the new ones and we did not clean up the Count message

since it is deprecated. TODO clean these up so the decoder is really

consistent.

2. Enabled the EnumerationContext Timer and removed code for alternate

non-thread solution.

17 April 2014

1. Reorganized the lock/unlock for handling the EnumerationContext because

there were thread windows (i.e. using the context after it was released

by other thread).

2. Modified code for the InteroperationTimerThread and deleted old code that

allowed this whole thread to by bypassed.

3. Internationalized a number of CIMOperationRequestDispatcher CIMException

response messages.

4. Fixed stress tests in Client/tests/pullop that were getting timeout. The

issue was not the pull code but that fact that the idle client timeout

appears to be measureing to the end of the operation and the operation

was taking more than 40 seconds which is the default timeout. The idle

timeout takes no account of the fact that chunks are being regularly

delivered.

5. Several minor code changes.

NOTE: At this point the code passes extensive tests of the pull operations

both in OOP and none OOP mode (but with lots of diagnostics that may

be affecting timing).

10 April 2014

1. Fix issues causing failure with repeated pull operations.

2. Consolidate some of the CIMOperationRequestDispatcher.cpp template code

7 April 2104

MergeOut of head of tree.

7 April 2014

1. Permanently fixed issue with getting correct number of objects on response.

This was introduced when did a temp fix to the OOP processing, in particular

removed the condition variable wait in the CIMOperationDispatcher handle

functions for opens and pulls. This moved the functionality to kick off

open and pull responses to the provider threads if there are not enough

objects when the handle is processed. Also added a variable to allow us to

test with either a) responses are required to satisfy the original

request size or) b, responses are required only to return some objects.

We will add statistics to see which of these works best.

2. Modified WsmProcessor EnumerationContext class since the name conflicts

with the pull Operation EnumerationContext class.

3. Created a new intermediate level of CIMMessage, the CIMPullResponseData

Message so that all of the open and Pull responses can use common code

since there are only two variables (endOfSequence and EnumerationContext)

and they are common across all the open and pull responses.

4. Removed a number of diagnostics.

5. Cleaned up the Dispcatcher so that the open and pulls have common response

code and that code can be used from the dispatcher handle functions and

the provider response functions.

31 March 2014 - Checkin

1. Fixed issues in OOP processing of pull operations, in particular

issues with cimxml output format when processed through the

*InternalXmlEncoder functions.

2. Clean up some of the internalXml functionality

3. Found issues causing timeout with a particular provider. The issue

is that the dispatcher and monitor end up using the same thread so the

condition variable in the dispatcher thread stops the monitor. Turned

off the conditionVariable in getCache for the moment which means that

we get number of responses for open... with 0 objects before the

providers can begin to respond. This is only for test.

4. Added some statistics for enumerations and display the statistics

when we close the server (same as cache statistics)

12 March 2014 - Mergeout and Mergein

1. Mergeout to head of tree for this date and mergein for patch update

to bug 9676

2. Extensions to pullop tests program and tests.

3. Added some diagnostics in looking for OOP issue.

4. Removed a number of diagnostics messages and cleaned up code in

dispatcher to simplify pull operation processing.

15 December 2013

1. Mergeout and mergein up to 15 December 2013

2. Clean up issues from tests documented in bug 9676 last week.

3. Clean up some code in dispatcher

4. Remove the filter function from ResponseStressc++Provider.

21 November 2013

1. Mergeout from head of tree to 21 November 2013.

18 November 2013

1. Cleanup of a bunch of minor errors and completion of all of the code for

the openQueryInstances except for the PullInstances in Dispatcher and

the aggregator function.

2. OpenqueryInstances added to cimcli.

13 October 2013 CVS branch update.

1. Integrated bug 9786 into the branch. Note that we need to test the

generated statistics.

2. Mergeout executed to update to head of tree as of 8:00 am 13 October 2013.

3. Cleaned up several errors in OOP processing. Note that there is at least

one issue left when we to a pull on ManagedElement in at least one of the

namespaces.

4. Cleaned up some of the outstanding diagnostic code

5. Generally passes all tests except for one test of pullop where it is trying

to pull enum instances CIM_ManagedElement from a particular namespace.

NOTE: I did not make comments here for changes in October despite the fact

that I did 2 mergouts, number of fixes, and a mergein.

30 September 2013 - CVS Update

Mergeout head of tree up to 29 September 2013.

29 September 2013. CVS update.

1. Modified calls to statisticalData.cpp to a) directly call with request

type, b) incorporate the open, pull, etc. messages. However, since these

are not part of the CIM class, we must do something special with them.

See bug 9785 for full solution to this issue.

2. Corrected OOP interface to enable new flag to indicate internal operations

and set host, etc.

3. Add code to CQLOperationsDispatcher and WQLOperationDispatcher to clean

up CIMResponseDataCounter after filtering.

4. Modified ProviderAgent to set Host info for some pull operations.

5. Added new flag to CIMBinMsgSerializer and Deserializer.

17 September 2013 CVS update (Actually two different updates over 3 days)

1. Clean up some issues in CIMMessage.h and CIMMessage.cpp

2. Extend OpenExecQuery to WQL and CQL processors but return not complete

3. Remove memory leak in EnumerationContext and EnumerationContextTable

handling.

4. Created template functions for much of the pull operations.

5. Reversed order of queryLanguage and query (and changed names to match

execQuery) in client and server. Note that these are the execQuery

WQL and CQL filters and NOT FQL filters.

6. Some code cleanup in dispatcher

7. Today, passes all tests in pullop but issue in alltests. For some reason

not finding CIMObjectManager instance. Also, leaves enumeration contexts

if client terminates since cleanup thread not operating.

8. XML from OOP not correctly processed.

14 September 2013 CVS update

Merged out up to 25 August. Cleaned up all operations and standardized code.

At this point the non pull operations code is in a set of templates but the

pull is not yet.

Fixed a significant number of problems so that it appears that the operations

except for OpenExecQuery run stably, at least with the pullop test program.

Note that there is a problem in that the Interop control provider is not

returning its singleton wbemserver object for some reason. Causes a test

failure

Fixed for 16 June CVS Update

1. Cleaned up the enumerationContext and Table release functions and tested

to confirm that we do not lose memory in either normal sequences or

sequences that close early. Cleaned up pullop and added more tests

Taged Before: PREAUG25UPDATE and after POSTAUG25UPDATE

Fixed for 9 June CVS update

1. Cleaned up code for OpenQueryInstances. Note that this is incomplete.

Line 113

Line 358

2 June 2013

Issues - KS

1. have not installed the binary move in CIMResponseData. Please run

with OPP off.

2. Some problem in the processing so we are getting server crashes.

Right no I am guessing that this is in the binaryCodec and am going to

expand the test tools to allow testing through the localhost.

3. Still way to many TODO and KS comments and KS_TEMPS. Removing bit by bit.

- Still way to many TODO and KS comments and KS_TEMPS. Removing bit by bit.

4. Env variable connection for the config parameters not installed.

- Runtime variable connection for the config parameters not installed. That

has been made into a separate bug (see bug 9819)

5. Issue with the threaded timer. For some reason during tests it

eventually calls the timer thread with trash for the parm (which is

Line 135

Line 376

EnumerationContext so that the outputter will just take a defined number

of objects directly from the gathering cache and save the second move.

8. Not yet passing all tests but getting closer now.

8. Not yet passing all tests but getting closer now. The major test that is

causing an error today is the execution of a full enumeration with the

9. Created a tag before this commit TASK_PEP317_1JUNE_2013.

forceProviders = true. This causes a client timeout sometimes.

10. Next Tag will be TASK_PEP317_2_JUNE_2013 in the task branch

===========================================

Line 163

Line 403

-OpenReferenceInstancePaths

-OpenAssociatiorInstances

-OpenAssociatorInstancePaths

-OpenQueryInstances

-PullInstancesWithPath

-PullInstancePaths

-PullInstances

-CloseEnumeration

-EnumerationCount

OpenExecQuery

Line 361

Line 603

The default of this parameter is to refuse operat

In the current release of Pegasus these are all compile time parameters.

NOTES On working with task branch.

Merge out Process

To keep our TASK branch in sync with the current head of tree we need

to do a regular merge out. the TaskMakefile contains the makefile

procedures to do this efficiently. NOTE: Following these procedures is

important in that you are merging out new material each time you do

the merge out. If you were just to repeatedly merge out, you would be

merging previously merged changes a second time causing a real mess.

Start with new directory and put TaskMakefile above pegasus (needed so you

have this file for the initial operations.

make -f TaskMakefile branch_merge_out BNAME=PEP317-pullop ## takes a long time

This checks out current head, merges it into task branch and sets tags

for the mergeout. Note that at the end of this step this work is

part of the TASK... branch.

NOW check for conflicts, errors, etc. that resulted from the merge.

Look for conflict flags, compare the results (I use linux merge as a

good graphic compare tool) and build and test. When you are satisfied

that the merge out is clean, you can commit the results to the TASK...

branch

To commit the work to this into Task branch

make -f mak/TaskMakefile branch_merge_out_commit BNAME=PEP317-pullop

or manually commit and finish as follows

cvs commit

make -f mak/TaskMakefile branch_merge_out_finish BNAME=PEP317-pullop

## This last step is important since it cleans up temporary tags to prepare

you for the next checkout

COMPARE TASKBRANCH WITH HEAD

In a new pegasus work space do same as above for merge out.

make -f TaskMakefile BNAME=PEP317-pullop

This produces a result which is all of the head merged into the branch.

A diff of this is all the new changes to the head of tree that you will

include into the merge.

Legend:

Removed from v.1.1.2.5
changed lines
	Added in v.1.1.2.31

No CVS admin address has been configured