(file) Return to readme.pulloperations CVS log (file) (dir) Up to [Pegasus] / pegasus

Diff for /pegasus/readme.pulloperations between version 1.1.2.28 and 1.1.2.34

version 1.1.2.28, 2014/05/01 18:58:23 version 1.1.2.34, 2014/05/29 23:55:34
Line 11 
Line 11 
    1. Binary operation from OOP.  Need to add counter to binary    1. Binary operation from OOP.  Need to add counter to binary
       protocol to be able to count objects in response. Generates       protocol to be able to count objects in response. Generates
       warnings in things like messageserializer and does not work with       warnings in things like messageserializer and does not work with
       OOP right now.  Corrected by converting to XML.        OOP right now.  Fixed by converting to XML. Concluded that we do not
         need to do this. The binary response is not really used often
         in the current environment So double mapping it is not a major issue.
         Leave this as FUTURE
    2. OpenExecQuery - Code is incomplete in that it does not include the    2. OpenExecQuery - Code is incomplete in that it does not include the
       return from the exec query function to the aggregator yet.        return from the exec query function to the aggregator yet. Code for Pull
    3. Code for Pull part of OpenQueryInstancesRequest a) should be part of        part of OpenQueryInstancesRequest a) should be part of the common
       the common CIMOperationRequestDispatcher execCommon code.        CIMOperationRequestDispatcher execCommon code. DONE, not tested. 29 May
    4. The changes to WQLCIMOperationRequestDispatcher and CQL... for handling     3. The changes to WQLCIMOperationRequestDispatcher and CQL... for handling
       pull not completed so we feed the responses back to the EnmerationContext       pull not completed so we feed the responses back to the EnmerationContext
       queues        queues. DONE Not tested 29 May
    3. Minor TODOs, diagnostics, etc. still in the code     4. Minor TODOs, diagnostics, etc. still in the code
    4. External runtime variables. Proposing that they be fixed for this release     5. Extension to avoid double move of objects in CIMResponseData (one
       rather than set by configuration.  This should be discussed.  Am making  
       this a separate bug.  See bug 9819 for the changes to cover this.  
    5. Consider moving some more of the code in dispatcher from templates to  
       common functions which would mean adding intermediate classes in  
       CIMMessage but would reduce code size. Currently the change that  
       we should make for this is to create a new message CIMPullRequestData...  
       between CIMRequestDataMessage and the Pull requests since they all  
       have exactly the same input and output pararameters (The  
       CIMResponseData hides the response object differences)  
    6. Extension to avoid double move of objects in CIMResponseData (one  
       into enumerationContext queue and second to new cimResponseData for       into enumerationContext queue and second to new cimResponseData for
       response.  Want to avoid second move by extending Open/Pull response       response.  Want to avoid second move by extending Open/Pull response
       messages to include count and CIMResponse data to count objects out       messages to include count and CIMResponse data to count objects out
       of queue when converting (avoids the second move). This would mean       of queue when converting (avoids the second move). This would mean
       extending the output writers to allow the count field to be supplied       extending the output writers to allow the count field to be supplied
       so they would only create output for up to the count supplied.        so they would only create output for up to the count supplied.(Make
    9. Add more static tests (currently only OpenEnumerateInstances and        this future beyond bug 9676)
      6. Add more static tests (currently only OpenEnumerateInstances and
       OpenEnumerateInstanceNames covered).       OpenEnumerateInstanceNames covered).
       Low priority because most of this except exact XML covered in other       Low priority because most of this except exact XML covered in other
       tests. note that we can only add very limited tests since a) no       tests. note that we can only add very limited tests since a) no
       way to test multiple opertions in sequence(i.e. open/pull) and        way to test multiple operations in sequence(i.e. open/pull) and
       cannot be sure how many responses will come back in all cases even       cannot be sure how many responses will come back in all cases even
       for open.       for open.
    10. Could clean up the CIMOperationRequestDecoder.cpp rejectCIMException     7. Clean up the CIMOperationRequestDecoder.cpp rejectCIMException
       further since there is some overlap.  That is low priority.        further since there is some overlap.  VERY Low priority.
    11. Correct issue between operations and HTTP where we are sending     8. Correct issue between operations and HTTP where we are sending
       trailers with exceptions.  Also correct issue where we are        trailers with exceptions. Modify response mechanisms so that we
       sending endOfSequence and EnumerationContext in response when        set non-chunked for all responses where we send error responses to
       we send CIMException.  DONE Except that we really need to get        avoid the trailers.
       rid of the trailers completely for pull operations.  Need to     9. It would be more efficient in dispatcher to always use exception for
       have flag to send as non trailer (probably non_chunked flag)         rejects and change the _reject functions so that they never return
          when they reject. This is VERY LOW PRIORITY and primarily saves
          a few lines of code in the reject functions and their calls.  Means we
          would code.
          _rejectIfEnumerationToBroad(...)
          _rejectIfThisParameterIncorrect(...)
   
          instead of
          if (_rejectIfEnum...)
          {
              return true
          }
          It would mean that the method trace for the handlers would not return
          an exit if we rejected. VERY LOW PRIORITY
       10. There are still a couple of template functions around the task of
          distributing requests to the multiple providers.
          In fact there are two similiar but different templates for
          the associators(i.e. assoc, ref, etc.) functions and the parallel
          openAssoc functions.  It would be nice to consolidate that logic and
          further to try to create a non-template form for those functions. LOW
          PRIORITY.
       11. External runtime variables. This bug leaves these variables as
         internal to CIMOperationRequestDispatcher.cpp.
         See bug 9819 for the changes to externalize these variables, both
         the runtime and buildtime variables.  The Work group discussion
         documents what the variables are and how they tie to statistics info.
         See the OpenPegasus Wiki, Pull operations work group.
       12. Not directly related to pull but now over half the code in
         WQLOperationRequestDispatcher.cpp and CQLOperationRequestDispatcher
         handle functions is just duplicated.  Need to create a common function
         and eliminate the duplicated code
       13. Left almost duplicate createContext function in EnumerationContextTab.
         Clean up code
   
  
    NEXT TASKS:    NEXT TASKS:
       b. Finish and test the OpenQueryInstances        a. finish 8, 11 2,3 above ( Finish by about 1 June)
       c. Clean up TODOs  
       d. Find issue that is causing occasional failures under load.  It  
          is probably a threading issue between the 3 possible threads  
          that use the EnumerationContext (request thread, provider thread,  
          timeout thread) and a place where not mutuxed, primarily the  
          timeout thread.  
  
   29 May 2014
   1. Correct issue in cimcli that was causing rejects of open operations when
      there were no filters requested. The standard default is WQL in cimcli
      so we overrode this for the pull operations.
   2. Clean up OpenQueryInstances in CIMMessage.h and CIMMessage.cpp.
   3. Modify CIMOperationRequestDispatcher and
      EnumerationContextTable.CreateContext to pass request rather than request
      parameters.
   4. Remove a number of diagnostic messages.  Note that there are still some.
      They are marked KS_TODO with with note to remove before checkin. They are
      all traces and validations.
   5. Correct error in inclusion of execinfo.h include in CIMOperationRequestDis.
      found by Ji Lee.
   6. Cleaned up execQuery and extended it for OpenQueryInstances.  ExecQuery
      tested but have not tested OpenQueryInstances yet. One more checkin and we
      should be able to close 2,3 above (OpenQueryInstances).
   
   26 May 2014
   1. Remove a number of diagnostics.
   2. Make cache size in EnumerationContextTable dynamic and remove function
      to set default values. MaximumEnums set from Dispatcher on constructor for
      EnumerationContextTable and table size set to 1/2 of maximum number of
      open contexts.
   3. Clean up some statistics in EnumerationContextTable
   4. Correct error in query and queryLanguage parameters in cimcli in that
      the default for queryLanguage is WQL but must be "" for pull operations.
      If WQL found they set it to "".
   
   
   9 May 2104
   1. Converted several  template functions in CIMOperationRequestDispatcher
      to real functions
   2. Added intermediate CIMMessage for CIMPullOperationRequestMessage since
      all of the pulls have exactly the same data. This allowed us to
      convert the template function processPullRequest from template to
      real function
   3. Added intermediate CIMMessage for CIMOpenOperationRequestMessage betweeh\n
      all of the Opens and the  CIMRequestData message.  This will allow
      common code to test all of these variables in all 6
      CIMOperationRequestDispatcher handleOpen... functions
   3. Added variable in  CIMOperationRequestDispatcher handleEnqueue to make
      releasing the original request conditional on return from the handle...
      for open... and pull... handlers.
      This allowed us to drop one place where we were creating a new request msg
      for the delayed response and use the original request.  This meant that
      we could convert the issueOpenOrPullResponse from template function to
      real function.
   4. Moved open and pull constructors in CIMMessage.h to CIMMessage.cpp. NOTE:
      openQueryInstances not moved.  Will do when we get this funciton running.
   5. Added test for correct namespace in pull operations.  Note that it is
      never really used but since supplied with request, we test to be sure it is
      same as open request namespace.  added internationalized exception for this.
   6. We should probably add same test to close just as an input parameter
      validation.
   6. Modified processPullRequest to close the enumeration context if
      incorrect response type received.  Before we just returned exception and
      left context open for next request.  Closing is much more logical since the
      client really did send an erronous request.
   7. Modified PullErrors to correctly test above changed in behavior.
   8. Removed a significant number of diagnostic messages.
   9. Added query and querylanguage parameters to cimcli.
   
   
   4 May 2014
   1. Clean interface with EnumerationContext timeout thread
   2. Remove more diagnostics
   3. Correct issue with enumerationContext Release that was causing
      failures during nightly tests.
   
   2 May 2014
   1. Remove Diagnostics from ResponseData.cpp
   2. Correct setup and start of EnumerationContextTimerThread
   3. Change limit on max number of enum contexts to be set from Dispatcher.
   4. Increase size of hashtable for enum contexts.
   5. Corrected issue causing failures in removeContext. Now runs through nightly
      tests most of the time.
 1 May 2014 1 May 2014
 1. Cleanup of code and variable names. 1. Cleanup of code and variable names.
 2. Removed namespace variable from EnumerationContext.  It was never used. 2. Removed namespace variable from EnumerationContext.  It was never used.

Legend:
Removed from v.1.1.2.28  
changed lines
  Added in v.1.1.2.34
No CVS admin address has been configured
 Powered by
ViewCVS 0.9.2