pegasus/readme.pulloperations - diff

Return to readme.pulloperations CVS log

Up to [Pegasus] / pegasus

Diff for /pegasus/readme.pulloperations between version 1.1.2.11 and 1.1.2.28

version 1.1.2.11, 2013/09/29 20:51:12

version 1.1.2.28, 2014/05/01 18:58:23

Line 11

1. Binary operation from OOP. Need to add counter to binary

protocol to be able to count objects in response. Generates

warnings in things like messageserializer and does not work with

OOP right now.

OOP right now. Corrected by converting to XML.

2. OpenExecQuery - Code is incorrect in that it used InstancesWithPath

2. OpenExecQuery - Code is incomplete in that it does not include the

where the spec is instances with no path. Need new function to wrap

return from the exec query function to the aggregator yet.

getInstanceElement(withoutPathElement) in XmlReader. Note that

Alternate is to put flag on InstancesWith Path to say no path

3. Code for Pull part of OpenQueryInstancesRequest a) should be part of

the common CIMOperationRequestDispatcher execCommon code.

4. The changes to WQLCIMOperationRequestDispatcher and CQL... for handling

pull not completed so we feed the responses back to the EnmerationContext

queues

3. Lots of minor TODOs, diagnostics, etc.

3. Minor TODOs, diagnostics, etc. still in the code

4. External runtime variables. Decide this as part of PEP. The variables

4. External runtime variables. Proposing that they be fixed for this release

exist in CIMOperationRequestDispatcher but not in CIMConfig. The primary

rather than set by configuration. This should be discussed. Am making

ones to consider are:

this a separate bug. See bug 9819 for the changes to cover this.

a. System maxObjectCount. Setting some maximum size on what a pull

5. Consider moving some more of the code in dispatcher from templates to

client can request (i.e. the maximum size of the maxObjectCount on

common functions which would mean adding intermediate classes in

Open... and pull operations.

CIMMessage but would reduce code size. Currently the change that

b. Pull interoperationTimeout (max times between operations). This is

we should make for this is to create a new message CIMPullRequestData...

the maximum number of seconds on the operationTimeout parameter of the

between CIMRequestDataMessage and the Pull requests since they all

Open operations

have exactly the same input and output pararameters (The

c. Maximum size of the responseCache before it starts backing up

CIMResponseData hides the response object differences)

responses to the providers.

6. Extension to avoid double move of objects in CIMResponseData (one

5. Decision on EnumerationContext timeout (separate thread or just

checks during other operations). Can we, in fact really keep the

enumeration context table and queue under control without monitoring

with a separate thread. We must monitor for:

a. Client operation that stop requesting (i.e. inter operation time

exceeds operationTimeout). Note that if it simply exceeds the time

the next operation does the cleanup. The issue is those clients that

simply stop and do not either close or go to completion.

b. We should protect against providers that no not every finish delivering

or take to long between deliveries. This does not exist in Pegasus

today

6. Clean up code in Dispatcher. Want to at least reduce the code for the

Open Operations to a set of templates so we know that the code is the

same for all operations. Right now the existing operations enum, assoc,

etc. are all in templates but not the open operations. Note that the

pull is a single template for both pullInstances and pullInstancePaths.

However, we might be able to reduce this to a single function by adding

a new level to CIMMessage.h (CommonPullResponse)

7. Extension to avoid double move of objects in CIMResponseData (one

into enumerationContext queue and second to new cimResponseData for

response. Want to avoid second move by extending Open/Pull response

messages to include count and CIMResponse data to count objects out

of queue when converting (avoids the second move). Big issue here

of queue when converting (avoids the second move). This would mean

with binary data since need to extend format to count it.

extending the output writers to allow the count field to be supplied

8. NEXT TASKS:

so they would only create output for up to the count supplied.

a. get the pull operations rather than a template into a single

9. Add more static tests (currently only OpenEnumerateInstances and

function by creating a new CIMPullResponse message in CIMMessage.h that

OpenEnumerateInstanceNames covered).

contains the pull data. Then we can use a single function to process all

Low priority because most of this except exact XML covered in other

pull operations.

tests. note that we can only add very limited tests since a) no

b. test the enumeration timeout thread

way to test multiple opertions in sequence(i.e. open/pull) and

c. New Mergout to bring up to to date again.

cannot be sure how many responses will come back in all cases even

d. Sort out issues with statisticalData since it really does not work

for open.

with Open and Pull operations

10. Could clean up the CIMOperationRequestDecoder.cpp rejectCIMException

further since there is some overlap. That is low priority.

11. Correct issue between operations and HTTP where we are sending

trailers with exceptions. Also correct issue where we are

sending endOfSequence and EnumerationContext in response when

we send CIMException. DONE Except that we really need to get

rid of the trailers completely for pull operations. Need to

have flag to send as non trailer (probably non_chunked flag)

NEXT TASKS:

b. Finish and test the OpenQueryInstances

c. Clean up TODOs

d. Find issue that is causing occasional failures under load. It

is probably a threading issue between the 3 possible threads

that use the EnumerationContext (request thread, provider thread,

timeout thread) and a place where not mutuxed, primarily the

timeout thread.

1 May 2014

1. Cleanup of code and variable names.

2. Removed namespace variable from EnumerationContext. It was never used.

3. Added test for max number of open enumerations. Right now it is fixed

and set about 100. Note that this is tied to the size of hash table

so that there is a issue with more dynamic setting of max and the

hash table size.

4. Removed several unused functions.

5. Found one possible issue causing thread conflict but not the core one

yet.

30 April

1. Added exception response to dispatcher for Limits exceeded on

CreateEnumerationContext. Returns Exceeded server limits CIMException.

2. Fixed possible deadlock where we were not unlocking EnumerationContext

under error condition

27 April - mergeout to head of tree

1. Mergeout of the code to the head of tree. Documented that mergeout in

the bug

27 April 2014

1. Clean up in a number of areas, mostly just code without changing

functionality.

2. Modified CIMMessage.h slightly to clarify names of the pull intermediate

messages (the common open and pull response);

3. Removed a number of diagnostics from CIMResponseData

4. Added new function to ResponseStressTestProvider to be able to terminate

output after a defined number of objects with a CIMException.

5. Removed a number of other TODOs

6. Corrected a couple of errors in the server message bundle.

7. Modified ResponseEncoder to only output the error for pull errors.

It was errounously outputting the EndOfSequence, EnumerationContext and

the error. This way, only the error is sent which is spec.

8. Removed number of TODOs and cleaned up a couple of others.

9. Added static tests for OpenEnumerateInstanceNames.

10. Modified a number of the temporary diagnostics to be permanent by

changing them to PEGASUS_DEBUG_ASSERTs

22 April 2014

1. Clean up some messages.

2. Still trying to find issue that randomly keeps messages in timeout

queue long after they have been closed and returned.

3. Fixed memory loss error.

4. Added zero reject for OperationTimeout because that effectively disables

the whole timeout mechanism so that enumerations could be started, never

completed by the client and would just hang around in memory. That

would be a significant DDOS attack (start very large enum with no

timeout) and never do pulls after open.

21 April 2014

1. Reorganized code in CIMOperationRequestDecoder.cpp ...Iparam classes.

Cleaned up the rejectCIMException code.

2. Cleanup some issues in the EnumerationContextTimeout Thread.

3. Fixed issue in pullop where it was using zero as default for default

operation timeout where it should have been NULL, the DMTF specified

default.

4. Enabled the test to reject 0 as operation timeout on a request and but

controled by a #define in CIMOperationRequestDispatcher.cpp

5. Added test for excessive new OperationContext entries in table.

18 April 2014

1. Internationalize remaining messages in CIMOperationRequestDecoder.cpp and

clean up the decoders for some of the messages so they use the

...Iparam classes. Note that we did not clean up all of the old message

decoders, just the new ones and we did not clean up the Count message

since it is deprecated. TODO clean these up so the decoder is really

consistent.

2. Enabled the EnumerationContext Timer and removed code for alternate

non-thread solution.

17 April 2014

1. Reorganized the lock/unlock for handling the EnumerationContext because

there were thread windows (i.e. using the context after it was released

by other thread).

2. Modified code for the InteroperationTimerThread and deleted old code that

allowed this whole thread to by bypassed.

3. Internationalized a number of CIMOperationRequestDispatcher CIMException

response messages.

4. Fixed stress tests in Client/tests/pullop that were getting timeout. The

issue was not the pull code but that fact that the idle client timeout

appears to be measureing to the end of the operation and the operation

was taking more than 40 seconds which is the default timeout. The idle

timeout takes no account of the fact that chunks are being regularly

delivered.

5. Several minor code changes.

NOTE: At this point the code passes extensive tests of the pull operations

both in OOP and none OOP mode (but with lots of diagnostics that may

be affecting timing).

10 April 2014

1. Fix issues causing failure with repeated pull operations.

2. Consolidate some of the CIMOperationRequestDispatcher.cpp template code

7 April 2104

MergeOut of head of tree.

7 April 2014

1. Permanently fixed issue with getting correct number of objects on response.

This was introduced when did a temp fix to the OOP processing, in particular

removed the condition variable wait in the CIMOperationDispatcher handle

functions for opens and pulls. This moved the functionality to kick off

open and pull responses to the provider threads if there are not enough

objects when the handle is processed. Also added a variable to allow us to

test with either a) responses are required to satisfy the original

request size or) b, responses are required only to return some objects.

We will add statistics to see which of these works best.

2. Modified WsmProcessor EnumerationContext class since the name conflicts

with the pull Operation EnumerationContext class.

3. Created a new intermediate level of CIMMessage, the CIMPullResponseData

Message so that all of the open and Pull responses can use common code

since there are only two variables (endOfSequence and EnumerationContext)

and they are common across all the open and pull responses.

4. Removed a number of diagnostics.

5. Cleaned up the Dispcatcher so that the open and pulls have common response

code and that code can be used from the dispatcher handle functions and

the provider response functions.

31 March 2014 - Checkin

1. Fixed issues in OOP processing of pull operations, in particular

issues with cimxml output format when processed through the

*InternalXmlEncoder functions.

2. Clean up some of the internalXml functionality

3. Found issues causing timeout with a particular provider. The issue

is that the dispatcher and monitor end up using the same thread so the

condition variable in the dispatcher thread stops the monitor. Turned

off the conditionVariable in getCache for the moment which means that

we get number of responses for open... with 0 objects before the

providers can begin to respond. This is only for test.

4. Added some statistics for enumerations and display the statistics

when we close the server (same as cache statistics)

12 March 2014 - Mergeout and Mergein

1. Mergeout to head of tree for this date and mergein for patch update

to bug 9676

2. Extensions to pullop tests program and tests.

3. Added some diagnostics in looking for OOP issue.

4. Removed a number of diagnostics messages and cleaned up code in

dispatcher to simplify pull operation processing.

15 December 2013

1. Mergeout and mergein up to 15 December 2013

2. Clean up issues from tests documented in bug 9676 last week.

3. Clean up some code in dispatcher

4. Remove the filter function from ResponseStressc++Provider.

21 November 2013

1. Mergeout from head of tree to 21 November 2013.

18 November 2013

1. Cleanup of a bunch of minor errors and completion of all of the code for

the openQueryInstances except for the PullInstances in Dispatcher and

the aggregator function.

2. OpenqueryInstances added to cimcli.

13 October 2013 CVS branch update.

1. Integrated bug 9786 into the branch. Note that we need to test the

generated statistics.

2. Mergeout executed to update to head of tree as of 8:00 am 13 October 2013.

3. Cleaned up several errors in OOP processing. Note that there is at least

one issue left when we to a pull on ManagedElement in at least one of the

namespaces.

4. Cleaned up some of the outstanding diagnostic code

5. Generally passes all tests except for one test of pullop where it is trying

to pull enum instances CIM_ManagedElement from a particular namespace.

NOTE: I did not make comments here for changes in October despite the fact

that I did 2 mergouts, number of fixes, and a mergein.

30 September 2013 - CVS Update

Mergeout head of tree up to 29 September 2013.

29 September 2013. CVS update.

1. Modified calls to statisticalData.cpp to a) directly call with request

type, b) incorporate the open, pull, etc. messages. However, since these

are not part of the CIM class, we must do something special with them.

See bug 9785 for full solution to this issue.

2. Corrected OOP interface to enable new flag to indicate internal operations

and set host, etc.

3. Add code to CQLOperationsDispatcher and WQLOperationDispatcher to clean

Line 130

Line 299

2 June 2013

Issues - KS

1. have not installed the binary move in CIMResponseData. Please run

with OPP off.

2. Some problem in the processing so we are getting server crashes.

Right no I am guessing that this is in the binaryCodec and am going to

expand the test tools to allow testing through the localhost.

3. Still way to many TODO and KS comments and KS_TEMPS. Removing bit by bit.

- Still way to many TODO and KS comments and KS_TEMPS. Removing bit by bit.

4. Env variable connection for the config parameters not installed.

- Runtime variable connection for the config parameters not installed. That

has been made into a separate bug (see bug 9819)

5. Issue with the threaded timer. For some reason during tests it

eventually calls the timer thread with trash for the parm (which is

Line 152

Line 317

EnumerationContext so that the outputter will just take a defined number

of objects directly from the gathering cache and save the second move.

8. Not yet passing all tests but getting closer now.

8. Not yet passing all tests but getting closer now. The major test that is

causing an error today is the execution of a full enumeration with the

forceProviders = true. This causes a client timeout sometimes.

9. Created a tag before this commit TASK_PEP317_1JUNE_2013.

10. Next Tag will be TASK_PEP317_2_JUNE_2013 in the task branch

===========================================

Line 180

Line 344

-OpenReferenceInstancePaths

-OpenAssociatiorInstances

-OpenAssociatorInstancePaths

-OpenQueryInstances

-PullInstancesWithPath

-PullInstancePaths

-PullInstances

-CloseEnumeration

-EnumerationCount

OpenExecQuery

Legend:

Removed from v.1.1.2.11
changed lines
	Added in v.1.1.2.28

No CVS admin address has been configured