|
version 1.4, 2001/12/22 02:06:41
|
version 1.8, 2001/12/27 16:56:49
|
|
|
|
| "+++++ passed all tests" | "+++++ passed all tests" |
| | |
| Extraneous output should be removed. | Extraneous output should be removed. |
| |
|
| |
7. All defined constants must begin with "PEGASUS_". |
| |
|
| |
8. All method must use the form myMethodName(). Many places |
| |
have my_method_name() (with underscores). |
| |
|
| |
9. Avoid use of (void). Use () instead. |
| |
|
| |
10. Either get rid of throw() declarations or use them |
| |
everywhere (perhaps they are not supported by some compilers). |
| |
|
| |
11. Avoid indenting "private:", "public:" and "protected". Use this |
| |
style: |
| |
|
| |
class X |
| |
{ |
| |
private: |
| |
... |
| |
public: |
| |
}; |
| |
|
| |
12. Use "Type* x" rather than "Type *x". |
| |
|
| |
13. Use "if (" rather than "if(". |
| |
|
| |
14. Avoid use of spaces around the condition: |
| |
|
| |
if( cond ) |
| |
|
| |
15. Keep all lines within 80 columns. |
| |
|
| |
16. Build fails on many Linux system (threading support problems). |
| |
|
| |
17. SSL is the default on Linux (is this okay?). |
| |
|
| |
19. Fix main logic (Unix v.s. Windows). |
| |
|
| |
21. Get rid of CIMIndication class. |
| |
|
| |
22. Revise licensing headers on all files. |
| |
|
| |
23. Add $Log$ |
| |
23. Add Revision 1.8 2001/12/27 16:56:49 mike |
| |
23. Add Added more review comments. |
| |
23. Add CVS directives to each file. |
| |
|
| |
24. Avoid inlining of large functions. |
| |
|
| |
25. FInd decent code formatter. |
Return to
CodeReviewNotes.txt
CVS log
Up to [Pegasus] / pegasus / doc / Attic